Repository navigation
Conversation
Port of fsspec/filesystem_spec#2353. The request class re-added the Authorization header on every hop to an .archive.org host without checking the scheme, so an https -> http redirect inside the domain, or an explicit http:// URL, sent the IA-S3 keys in clear text. With an https download URL (the default), plain http hops now get no header.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of fsspec/filesystem_spec#2353. The request class re-added the Authorization header on every hop to an .archive.org host without checking the scheme, so an https -> http redirect inside the domain, or an explicit http:// URL, sent the IA-S3 keys in clear text. With an https download URL (the default), plain http hops now get no header.
The threat is narrow. It needs archive.org to answer an https request with a redirect to http and someone listening on the network at that moment.