Skip to content

[OPIK-5585][FE]: udpate titles v2;#6112

Merged
aadereiko merged 10 commits intomainfrom
sashaa/OPIK-5585/udpate-titles-v2
Apr 13, 2026
Merged

[OPIK-5585][FE]: udpate titles v2;#6112
aadereiko merged 10 commits intomainfrom
sashaa/OPIK-5585/udpate-titles-v2

Conversation

@aadereiko
Copy link
Copy Markdown
Collaborator

@aadereiko aadereiko commented Apr 7, 2026

Details

Standardize page titles and "Create new" button placement across all v2 pages, and rename InsightsPage to ProjectDashboardsPage.

image image image image image image image image image image image

Moved "Create new" buttons from the toolbar row to the page title section (right-aligned next to the title) on all list pages:

  • ProjectsPage — "Create new project"
  • PromptsPage — "Create new prompt"
  • EvaluationSuitesPage — "Create new"
  • ExperimentsPage — "Create new experiment"
  • AnnotationQueuesPage — "Create new queue"
  • OnlineEvaluationPage — "Create new rule"
  • DashboardsPage — "Create new dashboard"
  • FeedbackDefinitionsTab — "Create new feedback definition"

Removed ExplainerDescription / ExplainerCallout blocks below page titles to reduce vertical padding between the title and page content.

Changed title style from comet-title-l to comet-title-xs where applicable.

InsightsPage → ProjectDashboardsPage rename

Renamed the project-scoped "Insights" page to "Dashboards" to align naming with the workspace-level Dashboards page:

  • Directory: InsightsPage/ProjectDashboardsPage/
  • Files: InsightsPage.tsx, InsightsViewSelector.tsx, InsightsViewDialog.tsx, InsightsViewItems.tsxProjectDashboardsPage.tsx, ProjectDashboardViewSelector.tsx, ProjectDashboardViewDialog.tsx, ProjectDashboardViewItems.tsx
  • Components/types: All Insights* prefixes renamed to ProjectDashboard*
  • Router: route variable insightsRouteprojectDashboardsRoute, URL path /insights/dashboards, title "Insights" → "Dashboards"
  • Sidebar menu: label "Insights" → "Dashboards", path updated to /dashboards
  • Redirects: TracesTabRedirect updated to redirect ?tab=insights, ?tab=metrics, and ?view=dashboards to /dashboards

AgentConfigurationTab

Added page title "Agent configuration" (comet-title-xs) and removed the "Agent configuration" and "Version history" sub-headers.

Files changed

Change checklist

  • User facing
  • Documentation update

Issues

  • OPIK-5585

AI-WATERMARK

AI-WATERMARK: yes

  • Tools: Claude Code
  • Model(s): Opus 4.6

Testing

  • Manually
  • npm run lint
  • npm run typecheck

Documentation

@aadereiko aadereiko added the test-environment Deploy Opik adhoc environment label Apr 7, 2026
@github-actions github-actions Bot added Frontend typescript *.ts *.tsx and removed test-environment Deploy Opik adhoc environment labels Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

🔄 Test environment deployment process has started

Phase 1: Deploying base version 1.10.60 (from main branch) if environment doesn't exist
Phase 2: Building new images from PR branch sashaa/OPIK-5585/udpate-titles-v2
Phase 3: Will deploy newly built version after build completes

You can monitor the progress here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

📋 PR Linter Failed

Incomplete Issues Section. You must reference at least one GitHub issue (#xxxx), Jira ticket (OPIK-xxxx), CUST ticket (CUST-xxxx), DEV ticket (DEV-xxxx), or DND ticket (DND-xxxx) under the ## Issues section.

@aadereiko aadereiko changed the title [OPIK-5585]: udpate titles v2; [OPIK-5585][FE]: udpate titles v2; Apr 7, 2026
@aadereiko aadereiko requested review from a team and awkoy April 7, 2026 16:56
Comment thread apps/opik-frontend/src/v2/pages/ProjectsPage/ProjectsPage.tsx
Comment thread apps/opik-frontend/src/v2/pages/PromptsPage/PromptsPage.tsx Outdated
Comment thread apps/opik-frontend/src/v2/router.tsx
@CometActions
Copy link
Copy Markdown
Collaborator

Test environment is now available!

To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml)

Access Information

The deployment has completed successfully and the version has been verified.

@CometActions
Copy link
Copy Markdown
Collaborator

🌙 Nightly cleanup: The test environment for this PR (pr-6112) has been cleaned up to free cluster resources. PVCs are preserved — re-deploy to restore the environment.

@aadereiko aadereiko force-pushed the sashaa/OPIK-5585/udpate-titles-v2 branch from 75394f1 to d03d87f Compare April 8, 2026 17:59
@CometActions
Copy link
Copy Markdown
Collaborator

🌙 Nightly cleanup: The test environment for this PR (pr-6112) has been cleaned up to free cluster resources. PVCs are preserved — re-deploy to restore the environment.

@aadereiko aadereiko added the test-environment Deploy Opik adhoc environment label Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

🔄 Test environment deployment process has started

Phase 1: Deploying base version 1.11.1-4850 (from main branch) if environment doesn't exist
Phase 2: Building new images from PR branch sashaa/OPIK-5585/udpate-titles-v2
Phase 3: Will deploy newly built version after build completes

You can monitor the progress here.

@CometActions
Copy link
Copy Markdown
Collaborator

Test environment is now available!

To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml)

Access Information

The deployment has completed successfully and the version has been verified.

@CometActions
Copy link
Copy Markdown
Collaborator

🌙 Nightly cleanup: The test environment for this PR (pr-6112) has been cleaned up to free cluster resources. PVCs are preserved — re-deploy to restore the environment.

@CometActions CometActions removed the test-environment Deploy Opik adhoc environment label Apr 10, 2026
@aadereiko aadereiko force-pushed the sashaa/OPIK-5585/udpate-titles-v2 branch from d03d87f to 17b0102 Compare April 10, 2026 13:33
@aadereiko aadereiko added the test-environment Deploy Opik adhoc environment label Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔄 Test environment deployment process has started

Phase 1: Deploying base version 1.11.3-4876 (from main branch) if environment doesn't exist
Phase 2: Building new images from PR branch sashaa/OPIK-5585/udpate-titles-v2
Phase 3: Will deploy newly built version after build completes

You can monitor the progress here.

Comment on lines +333 to +341
<div className="pt-4">
<div className="mb-1 flex items-center justify-between">
<h1 className="comet-title-l">Alerts</h1>
<h1 className="comet-title-xs">Alerts</h1>
{canUpdateAlerts && (
<Button variant="default" size="xs" onClick={handleNewAlertClick}>
<Plus className="mr-1 size-4" />
Create alert
</Button>
)}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header block is duplicated across list pages with only title/button/onClick differing — should we extract it into a shared <PageSectionHeader title="..." action={{ label, icon, onClick }} />?

Finding type: Code Dedup and Conventions | Severity: 🟢 Low


Want Baz to fix this for you? Activate Fixer

@CometActions
Copy link
Copy Markdown
Collaborator

Test environment is now available!

To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml)

Access Information

The deployment has completed successfully and the version has been verified.

@CometActions
Copy link
Copy Markdown
Collaborator

🌙 Nightly cleanup: The test environment for this PR (pr-6112) has been cleaned up to free cluster resources. PVCs are preserved — re-deploy to restore the environment.

@CometActions CometActions removed the test-environment Deploy Opik adhoc environment label Apr 11, 2026
@CometActions
Copy link
Copy Markdown
Collaborator

🌙 Nightly cleanup: The test environment for this PR (pr-6112) has been cleaned up to free cluster resources. PVCs are preserved — re-deploy to restore the environment.

1 similar comment
@CometActions
Copy link
Copy Markdown
Collaborator

🌙 Nightly cleanup: The test environment for this PR (pr-6112) has been cleaned up to free cluster resources. PVCs are preserved — re-deploy to restore the environment.

@aadereiko aadereiko added the test-environment Deploy Opik adhoc environment label Apr 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔄 Test environment deployment process has started

Phase 1: Deploying base version 1.11.3-4876 (from main branch) if environment doesn't exist
Phase 2: Building new images from PR branch sashaa/OPIK-5585/udpate-titles-v2
Phase 3: Will deploy newly built version after build completes

You can monitor the progress here.

@CometActions
Copy link
Copy Markdown
Collaborator

Test environment is now available!

To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml)

Access Information

The deployment has completed successfully and the version has been verified.

@aadereiko aadereiko force-pushed the sashaa/OPIK-5585/udpate-titles-v2 branch from 17b0102 to 84cb0b2 Compare April 13, 2026 10:55
Copy link
Copy Markdown
Contributor

@JetoPistola JetoPistola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the v2 page-title / Create-button standardization. No correctness issues — just a few consistency nits flagged inline.

🤖 Review posted via /review-github-pr

/>
<h1 className="comet-title-xs truncate break-words">Experiments</h1>
<Button variant="outline" size="xs" onClick={handleNewExperimentClick}>
<Info className="mr-1 size-3.5" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 suggestion | Consistency

Every other "Create" button standardized in this PR (Projects, Prompts, Dashboards, Annotation queues, Alerts, Online evaluation rules, Feedback definitions) uses the Plus icon. The Info icon here looks like a leftover from the previous button — switching to Plus would match the rest.

Suggested change
<Info className="mr-1 size-3.5" />
<Plus className="mr-1 size-4" />

(also update the lucide-react import on line 3 to use Plus instead of Info)

🤖 Review posted via /review-github-pr

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks uglier with size-4, but a good comment :)

return (
<div className="pt-6">
<div className="pt-4">
<div className="mb-1 flex items-center justify-between">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 suggestion | Consistency

This page kept mb-1 on the title row (and the ExplainerDescription block on line 343 below the title), while every other list page in this PR was migrated to mb-4 and had its explainer block removed (e.g. ProjectsPage, PromptsPage, DashboardsPage, AnnotationQueuesPage, OnlineEvaluationPage). Was this intentional, or should AlertsPage follow the same pattern?

🤖 Review posted via /review-github-pr

{noData && canCreateDashboards && (
<Button variant="link" onClick={handleNewDashboardClick}>
Create new dashboard
<Plus className="mr-2 size-4" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 nit | Style

The header "Create dashboard" button on this page (and across the PR) uses mr-1 for the icon spacing — only the no-data variant here uses mr-2.

Suggested change
<Plus className="mr-2 size-4" />
<Plus className="mr-1 size-4" />

🤖 Review posted via /review-github-pr

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit e0d06b0 addressed this comment by updating the icon spacing on the no-data “Create dashboard” button from mr-2 to mr-1, matching the rest of the header buttons.

<h1 className="comet-title-l">Optimize a prompt</h1>
<h1 className="comet-title-xs">Optimize a prompt</h1>
<div className="flex gap-2">
<Button variant="outline" size="sm" onClick={onCancel}>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 nit | Style

Title moved to comet-title-xs but the adjacent Cancel/submit buttons still use size="sm". The new convention in this PR pairs the xs title with size="xs" action buttons.

🤖 Review posted via /review-github-pr

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was required by design

@@ -57,13 +57,13 @@ describe("TracesTabRedirect", () => {
it("redirects ?tab=insights to /insights", () => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 nit | Tests

Test descriptions on lines 57, 63, 93, and 158 still read "to /insights" but the assertions now check /dashboards. The it(...) strings should be updated so the test names match what they verify.

🤖 Review posted via /review-github-pr

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit e0d06b0 addressed this comment by updating the four it(...) descriptions to mention /dashboards, matching the assertions for those redirects.

}

// Legacy ?view=dashboards → insights
// Legacy ?view=dashboards → dashboards
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 nit | Comment

With the route renamed, this reads as a tautology (?view=dashboards → dashboards). Consider dropping or clarifying intent, e.g. // Legacy ?view=dashboards param from the old Insights tab.

🤖 Review posted via /review-github-pr

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit e0d06b0 addressed this comment by removing the tautological comment so the code no longer contains the confusing remark about ?view=dashboards.

JetoPistola
JetoPistola previously approved these changes Apr 13, 2026
Copy link
Copy Markdown
Contributor

@JetoPistola JetoPistola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — consistent sweep across v2 pages. Inline nits are non-blocking.

🤖 Approved via Claude Code

Copy link
Copy Markdown
Contributor

@JetoPistola JetoPistola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving — addressed nits look good (mr-1 fix, test names, comment cleanup).

🤖 Approved via Claude Code

@aadereiko aadereiko merged commit ff276d6 into main Apr 13, 2026
10 checks passed
@aadereiko aadereiko deleted the sashaa/OPIK-5585/udpate-titles-v2 branch April 13, 2026 11:21
thiagohora pushed a commit that referenced this pull request Apr 13, 2026
* [OPIK-5585]: update titles of v2;

* eslint issues;

* update workspace level components;

* eslint issue;

* update routing and titles;

* conflicts resolve;

* update imports;

* resize create buttons;

* align buttons;

* fix pr reviews;

---------

Co-authored-by: aadereiko <aliaksandr@comet.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend test-environment Deploy Opik adhoc environment typescript *.ts *.tsx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants