No Jira: Adjust Logging Output#557
Open
mikejritter wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Why are we doing this? (with JIRA link)
No jira. This is some post-upgrade cleanup that I had been wanting to do. For each change:
show_sql - This was nice to have during dev to confirm that the ant task was working as expected and making the expected changes in the db. Now it is simply adding noise to the nightly build logs.
XML Marshalling - Most of the extensions for procedures will end up triggering this, and it's really not a fatal exception. I suppose a WARN could work for it as well, but the exception often makes it look like a red herring. Note that I left the exception in as DEBUG logging is not enabled in prod but it can be removed.
DataSource Config - I didn't really see the benefit of logging the datasource configuration directly to the log, and the logging there was quite noisy. Adjusted to output the filename instead and change log levels accordingly.
How should this be tested? Do these changes have associated tests?
ant importcan be run. The sql output should no longer be show.Dependencies for merging? Releasing to production?
No dependencies. I did notice some other issues when running tests related to the Apache HttpClient, but I'll make a new ticket for that.
Has the application documentation been updated for these changes?
n/a
Did someone actually run this code to verify it works?
@mikejritter tested the show_sql and xml marshalling logging locally
Have any new security vulnerabilities been handled?
n/a