POC: Support file versioning for sharepoint - #566
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for uploading file content as a new, named version of a file using the alpha CDF file-versioning API via add_io_to_upload_queue_as_version. It refactors the existing upload logic to share common retry and threading plumbing through a new _submit_upload helper. Feedback on these changes suggests wrapping the on_version_uploaded callback in a try-except block to prevent callback exceptions from triggering broken upload retries, and adding a defensive check to ensure upload_urls is not empty before accessing it.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #566 +/- ##
==========================================
- Coverage 83.97% 83.42% -0.55%
==========================================
Files 46 46
Lines 4686 4725 +39
==========================================
+ Hits 3935 3942 +7
- Misses 751 783 +32
🚀 New features to boost your workflow:
|
No description provided.