Skip to content

Tidy up users endpoint - #129

Open
pbochis wants to merge 1 commit into
coduno:masterfrom
pbochis:refactor-user-endpoint
Open

Tidy up users endpoint#129
pbochis wants to merge 1 commit into
coduno:masterfrom
pbochis:refactor-user-endpoint

Conversation

@pbochis

@pbochis pbochis commented Oct 8, 2015

Copy link
Copy Markdown
Contributor
  • GET /users now returns all the users, as expected
  • add GET /invitations which will return all users invited by a company

@pbochis

pbochis commented Oct 8, 2015

Copy link
Copy Markdown
Contributor Author

If this will be merged, please also merge (this)[https://github.com/coduno/app/pull/119] otherwise app will break.

Comment thread controllers/user.go Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else is not needed, as the if above will return.

@pbochis
pbochis force-pushed the refactor-user-endpoint branch 2 times, most recently from 64affaf to 9606ee5 Compare October 9, 2015 10:15
 * GET /users now returns all the users, as expected
 * add GET /invitations which will return all users invited by a company
@pbochis
pbochis force-pushed the refactor-user-endpoint branch from 9606ee5 to bc1f9f7 Compare October 9, 2015 10:22
@pbochis pbochis mentioned this pull request Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants