Fix #699 -- Gracefully handle None value from active_queues in Celery#700
Merged
codingjoe merged 3 commits intocodingjoe:mainfrom Apr 9, 2026
Merged
Conversation
codingjoe
reviewed
Apr 8, 2026
Owner
codingjoe
left a comment
codingjoe
left a comment
There was a problem hiding this comment.
Hi @saschabuehrle,
Thanks for reaching out and providing a patch.
I think this can either be solved with a tiny or {} change, or you catch the attribute error. Both work for me.
Extra kudos for the test!
Cheers!
Joe
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
==========================================
- Coverage 99.74% 99.74% -0.01%
==========================================
Files 13 13
Lines 787 786 -1
==========================================
- Hits 785 784 -1
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
codingjoe
approved these changes
Apr 9, 2026
Owner
codingjoe
left a comment
codingjoe
left a comment
There was a problem hiding this comment.
I took the liberty to amend a commit.
codingjoe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #699
inspect(...).active_queues()can returnNonewhen the broker is restarting. This makescheck_active_queues()handle a missing inspect payload as an empty queue mapping, so it reports unavailable queues instead of crashing withAttributeError.Added a regression test for the
Nonereturn path.Greetings, saschabuehrle