Repository navigation
fix(approval): 退回候选节点改用后端执行历史列表 (#270) - #78
Merged
Merged
Conversation
PC / 移动端退回弹框此前从流程定义的全量节点(nodes)中截取到当前节点, 当前节点不在顶层节点列表时(条件/并行块内)会退化为全部节点,能选到 当前节点之后的节点,且顺序为定义顺序(A、B)而非最近优先(B、A)。 - flow-types 新增可选字段 backNodes(后端按执行历史下发,最近优先) - 新增 buildReturnNodeOptions(flow-approval-presenter):优先使用 backNodes;为空数组表示明确不可退回,不再回退;旧版后端缺失该字段时 保留原有按定义顺序截取的兼容逻辑 - PC / 移动端 return-view 改用该工具,不再自行截取流程定义节点 - 补充 return-nodes 单元测试与 changeset Closes #270
- changeset version:fixed 模式下全部 @coding-flow/* 包统一 0.2.20 -> 0.2.21 (flow-types / flow-core / flow-icons / flow-approval-presenter / flow-pc-ui / flow-pc-form / flow-pc-approval / flow-mobile-ui / flow-mobile-form / flow-mobile-approval / flow-design) - 生成各包 0.2.21 CHANGELOG(含 Updated dependencies 段) - 删除已消费的 .changeset/issue-270-return-back-nodes.md - 包间依赖使用 workspace:*,pnpm-lock.yaml 无需变更
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
PC / 移动端退回弹框从流程定义的全量节点(
flow.nodes)中截取到当前节点,导致(issue #270):改动
flow-types:FlowContent新增可选字段backNodes(后端按执行历史下发,最近优先)。flow-approval-presenter:新增buildReturnNodeOptions,优先使用backNodes;backNodes为空数组表示明确不可退回(如开始节点),不再回退;仅当旧版后端缺失该字段时保留原有按定义顺序截取的兼容逻辑。flow-pc-approval/flow-mobile-approval:return-view改用该工具,不再自行截取流程定义节点。tests/return-nodes.test.ts与 changeset。验证
pnpm -F @coding-flow/flow-approval-presenter test:102 个用例通过(含新增 5 个)pnpm run build:flow-pc-approval、pnpm run build:flow-mobile:构建通过test:flow-pc-approval/test:flow-mobile-approval中act(...) is not supported in production builds of React的失败为本地环境既有问题,dev基线同样失败(同一文件、同一数量)Closes #270