Skip to content

chore(tui): re-apply rustfmt to mcp.rs - #7106

Closed
Aboysky wants to merge 1 commit into
codewhale-hq:mainfrom
Aboysky:style/fmt-mcp
Closed

Aboysky wants to merge 1 commit into
codewhale-hq:mainfrom
Aboysky:style/fmt-mcp

Conversation

@Aboysky

@Aboysky Aboysky commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

What and why

cargo fmt --all -- --check currently fails on main: two spots in crates/tui/src/mcp.rs carry formatting drift. The Lint gate only runs fmt when a PR touches Rust code (the heavy change filter), so docs-only PRs never see it and the drift sat unnoticed — I hit it while verifying #7104.

This re-applies rustfmt. No code changes, so the diff is safe to review as formatting only.

Issue

No-Issue: formatting drift pre-existing on main, unrelated to any open issue.

How I tested it

$ cargo fmt --all -- --check   # before: Diff in crates/tui/src/mcp.rs:1442 / :4498
$ cargo fmt --all
$ cargo fmt --all -- --check && echo OK
OK

Toolchain note: first pass was made with rustfmt 1.8.0 (1.93.1) before my local stable updated; after updating to 1.10.0 (1.99.1, the same stable CI uses) the committed formatting still passes cargo fmt --all -- --check unchanged.

Red checks on this PR — all pre-existing on main (toolchain debt)

This PR's own change is formatting only; cargo fmt --all -- --check passes locally on rustfmt 1.10.0 (1.99.1) too. Every red check below reproduces identically on the other open Rust-touching PRs (#7101, #7103), so none of them are from this PR — they are main debt exposed by the Oct 13 stable (1.99.1), which no direct push to main ever exercised:

  • Lint — clippy::large_enum_variant in codewhale-protocol (turn: TurnSpec → suggests Box<TurnSpec>). Same lint in fix(commands): localize diff feedback #7101's run.
  • Test (ubuntu-latest) — panics at crates/cli/src/config_bundles.rs:2176, crates/cli/src/lib.rs:7344, crates/cli/src/lib.rs:7896, crates/tui/src/extension_host/tests.rs:3960, plus two cucumber PTY tests. Same panics in fix(commands): localize diff feedback #7101's run.
  • Test (windows-latest) — codewhale-tui (lib) fails to compile with warnings denied on the new rustc.
  • Version drift — check-bundled-plugin-claims.py: the first-party marketplace pin a5f1d210372f is never named in CHANGELOG.md.
  • Extension host runtimes (windows-latest) — build.mjs EXCERPTED guard: "src/dsh/dsh-message-compat.js no longer names @deepseek-ai/dsh-brand@0.2.1-rc.2". Both files last changed in 4cf2d2c.

Happy to help with any of these as separate PRs once you pick directions (the Box<TurnSpec> one is an API-shape call, and for the DSH provenance header I'd need the convention you want).

Checklist

  • One focused change, started from current main
  • Formatting only — no behavior change; cargo fmt --all -- --check passes
  • No user-facing feature change, so no docs/features.toml row needed

cargo fmt --all -- --check fails on main: two spots in crates/tui/src/mcp.rs
carry formatting drift. The Lint gate only runs fmt when a PR touches Rust
code, so docs-only PRs never hit it and the drift sat unnoticed. Re-apply
rustfmt; no code changes. Noticed while verifying codewhale-hq#7104.

Signed-off-by: Boyce <aboyskyi@gmail.com>
@Aboysky
Aboysky requested a review from Hmbown as a code owner October 27, 2026 15:35

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions github-actions Bot added the contribution-gate Author not yet in .github/APPROVED_CONTRIBUTORS; a maintainer grants access with /lgtm label Oct 27, 2026
@laozidabo laozidabo mentioned this pull request Oct 27, 2026
2 of 3 tasks
Hmbown added a commit that referenced this pull request Oct 27, 2026
style(tui): apply rustfmt to mcp and restore the lint gate. Required checks green on f8a6346 (Lint, Test (windows-latest), npm wrapper smoke). Maintainer commits on the branch: feature-gated Ollama dead_code expectation, Windows unused mut, merges of main incl. 715bb2e resolved to the branch's gating. Supersedes #7106 (same mcp.rs rustfmt) and #7109 (.gitattributes line now included). CW-7525.
@Hmbown

Hmbown commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Closing as a duplicate. Thank you @Aboysky: you spotted the mcp.rs rustfmt drift first (while verifying #7104), and the identical formatting landed in #7108, which also had to clear the clippy errors hiding behind it before Lint could pass.

@Hmbown Hmbown closed this Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution-gate Author not yet in .github/APPROVED_CONTRIBUTORS; a maintainer grants access with /lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants