Repository navigation
Conversation
cargo fmt --all -- --check fails on main: two spots in crates/tui/src/mcp.rs carry formatting drift. The Lint gate only runs fmt when a PR touches Rust code, so docs-only PRs never hit it and the drift sat unnoticed. Re-apply rustfmt; no code changes. Noticed while verifying codewhale-hq#7104. Signed-off-by: Boyce <aboyskyi@gmail.com>
3 tasks done
2 of 3 tasks
Hmbown
added a commit
that referenced
this pull request
Oct 27, 2026
style(tui): apply rustfmt to mcp and restore the lint gate. Required checks green on f8a6346 (Lint, Test (windows-latest), npm wrapper smoke). Maintainer commits on the branch: feature-gated Ollama dead_code expectation, Windows unused mut, merges of main incl. 715bb2e resolved to the branch's gating. Supersedes #7106 (same mcp.rs rustfmt) and #7109 (.gitattributes line now included). CW-7525.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
cargo fmt --all -- --checkcurrently fails onmain: two spots incrates/tui/src/mcp.rscarry formatting drift. The Lint gate only runs fmt when a PR touches Rust code (theheavychange filter), so docs-only PRs never see it and the drift sat unnoticed — I hit it while verifying #7104.This re-applies rustfmt. No code changes, so the diff is safe to review as formatting only.
Issue
No-Issue: formatting drift pre-existing on
main, unrelated to any open issue.How I tested it
Toolchain note: first pass was made with rustfmt 1.8.0 (1.93.1) before my local stable updated; after updating to 1.10.0 (1.99.1, the same stable CI uses) the committed formatting still passes
cargo fmt --all -- --checkunchanged.Red checks on this PR — all pre-existing on
main(toolchain debt)This PR's own change is formatting only;
cargo fmt --all -- --checkpasses locally on rustfmt 1.10.0 (1.99.1) too. Every red check below reproduces identically on the other open Rust-touching PRs (#7101, #7103), so none of them are from this PR — they aremaindebt exposed by the Oct 13 stable (1.99.1), which no direct push tomainever exercised:clippy::large_enum_variantincodewhale-protocol(turn: TurnSpec→ suggestsBox<TurnSpec>). Same lint in fix(commands): localize diff feedback #7101's run.crates/cli/src/config_bundles.rs:2176,crates/cli/src/lib.rs:7344,crates/cli/src/lib.rs:7896,crates/tui/src/extension_host/tests.rs:3960, plus two cucumber PTY tests. Same panics in fix(commands): localize diff feedback #7101's run.codewhale-tui(lib) fails to compile with warnings denied on the new rustc.check-bundled-plugin-claims.py: the first-party marketplace pin a5f1d210372f is never named in CHANGELOG.md.build.mjsEXCERPTED guard: "src/dsh/dsh-message-compat.js no longer names @deepseek-ai/dsh-brand@0.2.1-rc.2". Both files last changed in 4cf2d2c.Happy to help with any of these as separate PRs once you pick directions (the
Box<TurnSpec>one is an API-shape call, and for the DSH provenance header I'd need the convention you want).Checklist
maincargo fmt --all -- --checkpassesdocs/features.tomlrow needed