Reorganize inline editing features#2431
Merged
Merged
Conversation
Move feature specs that load inline editing into `frontend/inlineEditing/features/`, parallel to the commenting layout. Specs import from the `inlineEditing` page objects module directly; the back-compat re-export in `pageObjects/index.js` is dropped. `sectionPadding-spec.js` is split: the 13 general padding rendering tests move to `frontend/features/` (no inline editing needed); the 3 selection-driven "forced padding" tests stay under `inlineEditing/`. `editorCommentBadges-spec.js` becomes `commentBadges-spec.js` since the directory now carries the "editor" context. All `inlineEditing/features/` describes gain an `inline editing` prefix so test names in CI output are scoped to the mode.
The `useContentElementCommandSubscription` and
`useContentElementEditorState` specs (`inFrontend` and `inEditorPreview`
variants) now go through `renderEntry` from the matching page objects
module instead of `renderInEntry(<Entry />)`. Single-element tests use
the new `contentElement: {ui: <Test />}` shorthand instead of
registering content element types separately; the specs move to
`frontend/features/` and `frontend/inlineEditing/features/`
respectively, so the mode is expressed by the file's location rather
than an `inFrontend` / `inEditorPreview` directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip percy]