Repository navigation
ci: check each release page for a Cloudflare challenge instead of version.txt - #470
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Every release since v0.8.0 has ended with a failed Release workflow, v0.11.1 included. The smoke test's "Homepage reachable" step gets a 403 from Cloudflare, so
sync-developis skipped and develop has to be fast-forwarded by hand.#196 skips the checks when Cloudflare challenges the runner, but it asks
/version.txt, and Bot Fight Mode only challenges the HTML pages. So that request got a 200, the deploy check passed ("Live on 9dd359e" on v0.11.1), and the homepage then got403withcf-mitigated: challenge.Now the deploy is still checked through
version.txt(with the same challenge check, in case that ever changes), and each page is judged by its own response: 200 passes, a Cloudflare challenge becomes a notice, anything else fails.Once a
RELEASE_TOKENsecret is in place (see the comment insync-develop), develop syncs on its own after a release. Until then that job runs and warns, so develop still gets synced by hand.How I tested this
/,/json-formatterand/sitemap.xmlpass with 200, and a missing page fails with 404.403withcf-mitigated: challenge, the step left one notice for them, and the job passed.