Skip to content

fix(meta-fetcher): normalize whitespace in page titles (#393) #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhushan4work wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(meta-fetcher): normalize whitespace in page titles (#393) #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/meta-fetcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export function parseMetaTags(html: string, baseUrl: string): MetaTags {

// Extract <title>
const titleMatch = html.match(/<title[^>]*>(.*?)<\/title>/is);
if (titleMatch) tags.title = decodeEntities(titleMatch[1].trim());
if (titleMatch) tags.title = decodeEntities(titleMatch[1]).replace(/[ \t\n\r\f]+/g, ' ').trim();

// Extract meta tags
for (const tag of findTags(html, 'meta')) {
Expand Down
11 changes: 11 additions & 0 deletions tests/lib/meta-fetcher.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,17 @@ describe('parseMetaTags', () => {
expect(tags.title).toBe('<Tom & Jerry "Show">');
});

it('collapses multiline indentation, internal tabs, and double spaces in title while preserving non-ASCII whitespace', () => {
const tags = parseMetaTags(
`<title>
Cutting\t\tcold starts in&nbsp;half with Fluid Compute
| Acme Blog
</title>`,
base,
);
expect(tags.title).toBe('Cutting cold starts in\u00a0half with Fluid Compute | Acme Blog');
});

it('does not decode uppercase or mixed-case entities that are not valid in HTML', () => {
const tags = parseMetaTags(
'<meta name="description" content="&APOS; &NBSP; &Amp;">',
Expand Down
Loading