Repository navigation
fix(meta-fetcher): decode HTML4 named entities - #397
Closed
SatriaBagusNurhadianto wants to merge 1 commit into
Closed
SatriaBagusNurhadianto wants to merge 1 commit into
SatriaBagusNurhadianto wants to merge 1 commit into
Conversation
Collaborator
|
@SatriaBagusNurhadianto please read the contributing guidelines before opening a pr , u should get urself assigned first before writing a fix, dont spam prs. comment on the issue and wait to get assigned first , closing this u may reopen once u get assigned . |
Member
|
Thanks @SatriaBagusNurhadianto. #396 wasn't assigned to you when you opened this, so per the Spam section of CONTRIBUTING.md this one gets the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed:
src/lib/html-entities.tsand expanded it to cover HTML4 named entities.decodeEntitiesregex to match entity names containing digits ([a-z][a-z0-9]*), so½and²decode.Object.hasOwnlookup for case-sensitive, prototype-safe decoding.Why:
Tests:
npm run test(meta-fetcher suite, 54 tests) passes.npm run buildsucceeds.Related: #396