Skip to content

fix: give leaderboard Card links accessible names #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anurag629 merged 1 commit into from
Oct 28, 2026
Merged

fix: give leaderboard Card links accessible names #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ export function leaderboardPage(
const login = escapeHtml(row.login);
const chip = standing(row, program, state.status);
const chipHtml = chip ? `<span class="chip ${chip.kind}">${escapeHtml(chip.text)}</span>` : "";
const card = `<a class="cardlink" href="/leaderboard/${escapeHtml(program.id)}/u/${encodeURIComponent(row.login)}" title="${login}'s share card">Card</a>`;
const card = `<a class="cardlink" href="/leaderboard/${escapeHtml(program.id)}/u/${encodeURIComponent(row.login)}" title="${login}'s share card" aria-label="${login}'s share card">Card</a>`;
const prList = row.prs
.map(
(pr) =>
Expand Down
7 changes: 7 additions & 0 deletions test/page.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,13 @@ describe("leaderboardPage", () => {
expect(html).toContain('<a class="cardlink" href="/leaderboard/2026-10/u/ada"');
});

it("gives each Card link the person's share card accessible name", () => {
const cards = html.match(/<a class="cardlink"[^>]*>Card<\/a>/g);
expect(cards).toEqual(board.rows.map(({ login }) =>
`<a class="cardlink" href="/leaderboard/2026-10/u/${login}" title="${login}'s share card" aria-label="${login}'s share card">Card</a>`
));
});

it("states the rules, the window and who the reward comes from", () => {
expect(html).toContain("Merged pull requests in chatcops, ogcops and toolbelt, Oct 1 to Oct 31, 2026 (UTC).");
expect(html).toContain('<p class="status running">Running now. 20 days left.</p>');
Expand Down
Loading