Skip to content

🤖 fix: VS Code webview does not load app/providers config (thinking floors, model list) #4766

Description

@ThomasK33

Problem

The VS Code webview never connects the app-config and providers-config stores (AppConfigStore, ProvidersConfigStore). The desktop app connects them in AppLoader (getProvidersConfigStore().setClient(api)); the webview does not. This has two visible effects:

  • Wrong thinking display. The selector shows the level raised to the model's built-in minimum (for example MED), not to the user's configured per-model minimum, so it can differ from the level the turn actually uses. The backend applies the configured minimum.
  • Empty model list. The composer's model list and model cycling have nothing to choose from; only the current model is shown.

Split out of #4755. PR #4765 fixed the settings overwrite there and deliberately stopped clamping the thinking level in the webview, because clamping with built-in floors raised turns above lower floors the user had configured.

Proposed fix

Connect these stores to the webview's bridge client. Before that, check which oRPC paths they call; for example the providers store uses providers.getConfig/onConfigChanged, which are allowed, and the app-config store's calls may not be. Allowlist only read paths that can be justified.

Refs #4755


Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high • Cost: $26.99

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions