docs: state who can read the aggregated API server CA key - #145
Merged
Merged
Conversation
The warning only named readers in the server's namespace. List every identity that can read coder-k8s-apiserver-tls, per deployment mode, and state that a narrower Role would not help in --app=all. Refs #143 Change-Id: I9a1795d5c00e0d68115c6379941ad18f7c0f1324 Signed-off-by: Thomas Kosiewski <tk@coder.com>
Member
Author
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #143. Step 1 of 3: docs only.
The warning on the serving-CA Secret (
coder-k8s-apiserver-tls) said only readers "in the server's namespace" can use its CA key. Readers with cluster-wide Secret access can too, and so can thecoder-k8sServiceAccount throughmanager-role.What changed
In
docs/how-to/deploy-aggregated-apiserver.md:--app=alla narrower Role would not help. One process runs the controller and the aggregated API server under one ServiceAccount, and the controller needs cluster-wide Secret access.Next
Steps 2 and 3 give standalone
--app=aggregated-apiserverdeployments their own ServiceAccount, with access to only this one Secret. This is where least privilege actually improves.Validation
cspell, markdownlint-cli2 and
make docs-check(mkdocs build --strict) pass, and the new anchors resolve.Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:medium