Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 546f02264e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| agent-tty = pkgs.stdenvNoCC.mkDerivation { | ||
| pname = "agent-tty"; | ||
| version = "0.5.0"; |
There was a problem hiding this comment.
Derive the Nix package version from package.json
When the next automated release updates package.json, this hard-coded value—and the duplicate cache version at line 52—will remain 0.5.0, because release-please-config.json:10 only registers README.md as an extra versioned file. The resulting Nix package will therefore expose stale derivation metadata even though the bundled CLI reports the new version; derive this value from package.json or add both occurrences to the release update process.
Useful? React with 👍 / 👎.
|
Thanks for this PR. I'm going to decline it, though. Findings from testing, in case they help an out-of-tree flake:
With the hash fixed, the package built on x86_64-linux and a real session worked. Heads-up: we're potentially moving from aube to pnpm (#176), so the dependency fetch would need to switch to pnpm. A flake in nixpkgs or your own repo is the better home for this. |
Summary
flake.lockand multi-system Nix flakenode-ptywith Nixpkgs toolingVerification
nix flake checkon x86_64-linuxnix flake check --all-systems --no-buildThe smoke check inspects the structured
doctor --jsonresult directly because an absent optional Playwright browser makes the overall doctor command nonzero even when PTY spawning succeeds.