Skip to content

fix: use repository pnpm version for command reviews - #4

Merged
sahilmob merged 1 commit into
mainfrom
codex/review-pnpm-package-manager
Oct 5, 2026
Merged

sahilmob merged 1 commit into
mainfrom
codex/review-pnpm-package-manager

Conversation

@sahilmob

@sahilmob sahilmob commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

/codex-review fails during pnpm setup when the reviewed repository's packageManager differs from the command workflow's hardcoded 10.19.0. This blocks codemod-app, which now declares pnpm 12.4.2, before any model request.

Pass an explicit empty pnpm_version so pnpm/action-setup reads the version from the checked-out package.json. This follows the reviewed commit and avoids version drift after future upgrades. The composite action's default is still available to callers that omit the input.

Validation: actionlint passed for both the source template and downstream workflow. Confirmed the template's consumers declare packageManager (codemod: 10.19.0; codemod-app: 12.4.2) and pnpm/action-setup v6 supports inferring that version. A full review requires the command workflow fix to reach the default branch.

Internal CI change; product/Wish documentation does not apply.

Update the managed source template so subsequent consumer syncs preserve this behavior.

@sahilmob
sahilmob merged commit 5b0d2cb into main Oct 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant