Repository navigation
fix: bind fork reviews to immutable commits - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork reviews could fetch a moving PR diff after verifying its commit IDs, allowing a concurrent push/reset to change the analyzed content. They could also publish a successful result that said the diff was unavailable.
This change fetches the diff, changed files, and inline comment locations by immutable base/head SHAs; rejects missing-diff results without anchored findings; and checks both the base and head before posting. Comparisons with 300 or more files fail closed because GitHub caps the returned file list. The posting job gains contents:read for the comparison endpoint, while analysis and posting remain on separate runners.
The fork workflow also pins the Codex CLI and Responses API proxy to 0.160.0 and rejects empty or floating version overrides.
Validation:
Adds a pull-request CI job to run the regression tests without secrets. Follow-up hardening for #2.