Repository navigation
test(e2e): open the "+n" popover on the settled spec page - #142
Merged
Merged
Conversation
The "+n" button is clickable once the planning answer is in, before the spec and dashboard answers. Those add a chip to the head row, the anchored popover moves with its trigger, and a press measured before the move lands outside the panel: a light dismiss, and the link stays hidden until the test times out. Wait for the network to settle before opening it.
web/e2e/.report/ and web/e2e/.results/ start with a dot, and upload-artifact skips hidden paths unless include-hidden-files is set. Every failed e2e run so far uploaded nothing: no trace, no screenshot.
The first fix waited for networkidle and still timed out once in CI, this time with no pending action named, which fits the wait itself never resolving on the runner. The chip that moves the row is the type chip: it arrives with the spec answer and is inserted in front of the stage chip. Wait for it instead; a DOM condition does not depend on background traffic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an intermittent failure of
e2e/breadcrumb.spec.ts› a "+n" list link selects the other block on the planning tree, and makes failed e2e runs upload their trace.Cause
The original failure (seen on a dependency PR: 1509 passed, this one timed out) has this call log: the list link becomes stable, then
<ui-card …> from <app-spec-dashboard> subtree intercepts pointer events, thenelement is not visibleuntil the timeout.[data-head-more]renders once the planning answer is in. The spec answer (/api/workspaces/harbor/specs/002) can still be on its way. When it arrives it inserts the type chip in front of the stage chip, so everything to its right shifts, the "+n" trigger included. The popover is anchored to that trigger and moves with it. A press measured before the shift lands on the dashboard card beside the panel, the nativepopover="auto"light-dismisses, and the link stays hidden.Checked with a throwaway probe (not committed) that holds the spec and dashboard answers until the popover is open: the chip row goes from
star, stage, priority, milestone, feature, +ntostar, type, stage, …, the open link moves, and the popover itself stays open (so it is the stray press that closes it, not a re-render).Change
[data-head-chip="type"]before opening the popover. Test only, no app code.include-hidden-files: trueon the Playwright upload.web/e2e/.report/andweb/e2e/.results/start with a dot, andupload-artifactskips hidden paths by default. Every failed e2e run so far uploaded nothing (No files were found with the provided path), which is why no trace was available here.History of this PR
The first commit waited for
networkidleinstead. Its CI run failed in the same test with a bareTest timeout of 30000ms exceededand no pending action named, which fits the network-idle wait itself not resolving on the runner. The DOM condition replaces it; it does not depend on background traffic.Verification
bun run e2e -- breadcrumb -g '"\+n" list link' --repeat-each=30: 30 passed.bun run e2e -- breadcrumb: 119 passed, 1 skipped (the compact-only fit).CI=1(two workers, CI's order): 1510 passed. The failure never reproduced locally; it needs the runner's timing.bun run check:staticandbun run check:leakpass.A single green CI run does not prove an intermittent fix. If it shows up again, the run now carries the trace.
The milestone and feature chip tests next to it also click right after
goto. The type chip can shift those too, but a plain link has no light dismiss, so the press still lands on it. Left as is.