test(opensearch1): skip demo security config install in OpenSearch1ClientTest#35
Merged
Merged
Conversation
…her test classes OpenSearch1ClientTest was the only Testcontainers-based test class still running the OpenSearch security demo config installer at container startup (via plugins.security.disabled=true), unlike the other four client tests which already disable it via DISABLE_INSTALL_DEMO_CONFIG and DISABLE_SECURITY_PLUGIN. This left it as the one deterministic outlier hitting the container startup wait-strategy timeout in CI. Aligns OpenSearch1ClientTest with the pattern already used by OpenSearch2ClientTest/OpenSearch3ClientTest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenSearch1ClientTestwas the only Testcontainers-based test class still running the OpenSearch security plugin's demo config installer at container startup (plugins.security.disabled=true), whileOpenSearch2ClientTest/OpenSearch3ClientTestalready skip it viaDISABLE_INSTALL_DEMO_CONFIG=true+DISABLE_SECURITY_PLUGIN=true.OpenSearch1ClientTestas the one class hitting the container startup wait-strategy timeout in CI, since it alone performs the extra demo-config install step during container boot.OpenSearch1ClientTestwith the already-proven pattern used by the other four Docker-backed client tests, removing the difference between the failing and passing test classes.Test plan
mvn -Dtest=OpenSearch1ClientTest test— 41/41 tests passmvn test(full suite, all Docker-backed classes included) — all greenmvn formatter:format license:format— no additional changes needed