Repository navigation
fix: adopt released core v0.19.4 and its compatible dependency graph - #70
Closed
antoinetoussaint-byte wants to merge 1 commit into
Closed
antoinetoussaint-byte wants to merge 1 commit into
antoinetoussaint-byte wants to merge 1 commit into
Conversation
Complete the released Core adoption from #62 using Core's v0.19.4 compatibility correction and only its required transitive version changes. Keep SDK pins, public APIs and the existing transport unchanged; document the selected release and graph constraints in README.md.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main and the published v0.0.12/v0.0.13 runtime still selected Core v0.19.1. This completes the released Core adoption associated with #62 by selecting v0.19.4, including its dependency-graph correction for stable client-go composition.
Only
go.mod,go.sum, and README.md change. Core's required transitive floors move genproto API/RPC, gRPC, OpenAPI errors/swag helpers, x/exp and x/sys;go.sumis tidied. SDK v0.3.2 and sdk-go/workcontext v0.1.0 remain selected. No Go source, public API or transport changes, replacements, excludes, or unreleased dependency APIs.Reuse and classification
This is a fix at the consuming runtime's dependency pin, reusing Core's released implementation and compatibility correction. It introduces no duplicate parser, verifier, transport or dependency workaround. README.md records the selected release and graph constraints: no structured-merge-diff/v7 and no kube-openapi newer than v0.0.0-20260721132016-d427ff9ee9ad.
PR #69 remains the separate transport migration and is untouched. Its owner authorized this minimal main migration and will re-pin its overlapping module files later. This is one self-contained PR from main, with no dependency on #69.
Review and validation
Fresh independent review accepted the exact three-file candidate, patch SHA-256
8f3f4afbd26b5aaec7016915f08081edeb8b69be12a9f8b833b6b96a96e3700d. The report is in the handbook workspace at.lazybox/artifacts/REVIEW-FINDING-3-solution-runtime-go.md.All local Go checks ran with Go 1.27.2 on darwin/arm64 under the local-only sandbox, offline dependency/toolchain settings, readonly modules during verification, and separate author/reviewer build caches.
go test -race ./... -count=1 -timeout=5mpassed (root 206.304s; passthroughtest 1.509s), plus build, vet, module verification, tidy consistency, formatting and diff checks. Public API listings are identical.Limits
The attempted managedfields runtime-test command failed at initialization because the published module lacks its referenced
api/openapi-spec/swagger.json; the separate build and test-binary compilation establish compile compatibility only. This does not claim compatibility with every client-go release or Kubernetes-server behavior.No real host/gateway, composition, hosted deployment, TLS/mesh-posture qualification, or external dependency advisory scan was performed. The pre-existing conflict between this runtime's application TLS and the handbook's mesh-owned in-cell transport remains separately scoped to #69. This dependency review does not qualify that posture or authorize deployment.
Draft for review only; no merge, tag or release is requested.