Repository navigation
fix: read the listen port from a bare host:port self endpoint - #36
Merged
Merged
Conversation
Codefly hands a service its own endpoint as a bare host:port (a rendered cell writes "localhost:8080"); url.Parse reads that as scheme "localhost" with no port, so every rendered solution refused to boot with 'unresolved listen port ""'. listenPort accepts both the bare form and a URL. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. On hosted staging, every rendered solution (
wiki/backend,lastlogin-go/backend) crash-loops at boot with:Codefly hands a service its own endpoint as a bare
host:port. The render writesCODEFLY__ENDPOINT__WIKI__BACKEND__HTTP__HTTP: "localhost:8080", and every host service's self endpoint has the same form.loadConfigranurl.Parseon it, and Go readslocalhost:8080as schemelocalhostwith no port, soPort()is empty andvalidate()refuses.Fix, at the owner.
listenPortreads the port from either form:net.SplitHostPortfor the bare address,url.Parsefor a URL (what a local run supplies).PORTstill wins when set.Test.
TestListenPortReadsEitherAddressFormcovers the bare form, URLs, IPv6 and the empty and portless cases.go vet ./...andgo test ./...pass.🤖 Generated with Claude Code