Repository navigation
fix(build): release binaries on Go 1.27.3 (GO-2026-6809) - #25
Open
antoinetoussaint-byte wants to merge 1 commit into
Open
antoinetoussaint-byte wants to merge 1 commit into
antoinetoussaint-byte wants to merge 1 commit into
Conversation
Raise the go directive from 1.27.0 to 1.27.3. Releases go through core's shared go-service-release.yml, which installs Go with `actions/setup-go` `go-version-file: go.mod`, so the directive is both the module floor and exactly the compiler that ships; go1.27.3 carries the crypto/x509 fix for GO-2026-6809. No `toolchain` line and no GOTOOLCHAIN pin are added: both are selectors that would hold the build back once the directive moves again. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Released
service-temporalagent binaries are compiled by go1.27.0, which is affected by GO-2026-6809 (crypto/x509; fixed in go1.27.3).Go literals found
go.modgo 1.27.0→go 1.27.3go-version-file, the shipped compiler).github/workflows/releaser.ymluses: codefly-dev/core/.github/workflows/go-service-release.yml@main, which runsactions/setup-gowithgo-version-file: go.mod.github/workflows/ci.ymluses: codefly-dev/core/.github/workflows/go-service-ci.yml@main(samego-version-file: go.mod)(
github.com/aws/smithy-go v1.27.8in go.mod is a dependency version, not a Go version.) NoGOTOOLCHAIN,go-version: "x.y.z",golang:image orgoreleaser-crossliteral exists in this repo. No backwards selector found.Mechanism
A
godirective is a floor; withsetup-gogo-version-file: go.modit is also exactly the compiler the release job installs. Raising the directive to 1.27.3 is the whole fix.go mod tidychanged nothing else.Verified locally
go build ./...andgo vet ./...exit 0.go build -o /tmp/temporal/agent . && go version -m /tmp/temporal/agent→/tmp/temporal/agent: go1.27.3go test ./...exits 1 with two failures,TestTemporalFullStackandTestTemporalSchemaUpgrade, both:CLI subprocess exited before it bound its control socket: exit status 1/codefly must start postgres.The subprocess (
/Users/antoine/go/bin/codefly run service -d …, a localdevelopmentbuild) fails withendpoint postgres/tcp declares unsupported visibility "external" (one of "private", "internal", "public").The same test fails identically on the base
go.mod(go 1.27.0), so it is the local CLI build against the test fixture, not this change. Every other test in the package passes. Nothing was skipped or weakened.Classification
Fix at the place that owns the behaviour (the module's own floor, which the release workflow reads).
Deliberately not done
toolchainline, noGOTOOLCHAIN=go1.27.3: both are backwards selectors that would pin the build below a future directive.Not verified
go versionline on this PR is the evidence thatsetup-goresolves the new directive.Do not merge without the owner's say-so.
🤖 Generated with Claude Code