Repository navigation
fix: embed factory guidance as the requested template - #26
Merged
Merged
Conversation
Builder.Load requests GETTING_STARTED through the template API, which reads the .tmpl asset. The plain markdown filename made every generated-service conformance load fail. Rename the asset and exercise actual creation-mode Load in a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix at the Swift factory owner: Builder.Load uses ApplyTemplateFrom, which resolves a .tmpl asset, but the embedded guidance had a plain .md filename. Actual codefly publish failed at generated-service conformance before Create. Rename the asset without changing its content and add a creation-mode Builder.Load regression over a real service fixture. Full Go tests, build and vet pass. Full release conformance will rerun after merge; no Swift runtime qualification is claimed by this unit run. Refs codefly-dev/core#622.