Repository navigation
test: assert restricted profile omits empty manifests (#16) - #17
Merged
antoinetoussaint-byte merged 1 commit intoAug 18, 2026
Merged
Conversation
Core v0.3.0's WithDeployment skips templates that render blank, so namespace.yaml and secret.yaml are no longer emitted as empty stubs under the restricted portable profile. Update the test to assert those files are absent instead of present-and-empty. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16.
Summary
WithDeploymentsetsSkipEmptyRender: true, so templates that render blank under the restricted portable profile (namespace.yaml,secret.yaml) are no longer written as empty stubs — empty stubs would otherwise be inventoried into the signed promotion bundle.TestRestrictedPortableDeploymentstill expected those files to exist-and-be-empty, so it failed on the missing file. The test now asserts they are absent, matching the new contract.Test plan
go test ./...passes