Repository navigation
fix(connect): the generated face's prose names no business-line word - #127
Merged
Merged
Conversation
The face's docstring said a SETTINGS frame is scanned "holding one entry". "holding" is a business-line word that module repositories' boundary gates refuse in every file they carry, and the face is written into the service's tree by sync, so a module that turns connect-endpoint on fails its own gate on generated output it may not edit. "keeping" says the same thing. Same class as service-go-grpc 0.1.65 (connect_gen.go). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126.
The generated Connect face's docstring said a SETTINGS frame is scanned "holding one entry".
holdingis a business-line word module repositories refuse in every file they carry, and sync writes this file into the service's tree, so a module that turnsconnect-endpointon fails its own boundary gate on output it may not edit (obin-ai/module-evaluation, scorer Connect face). "keeping" says the same thing. Same class as service-go-grpc 0.1.65.Classification: fix at the owner (the template is the source of the generated file).
Verified:
go test -count=1 -run Connect .green.🤖 Generated with Claude Code