Repository navigation
fix(test): the Connect-only sync test owns its containers - #114
Merged
antoinetoussaint-byte merged 1 commit intoOct 26, 2026
Merged
Conversation
`codefly publish` runs the source tests below the agent process, so the test binary inherits the agent's CODEFLY_CONTAINER_RECOVERY_SCOPE marker, which names a pid that is neither the test binary nor its parent. Core refuses to create a container under it, so TestConnectOnlyServiceSyncs (4c35bc0, #113) failed release-grade agent CI with "container recovery marker does not belong to this process or its launching parent" and aborted the 0.0.122 publish. GitHub CI sets no marker, so main was green. The test now calls ownTestContainers, as every other container-backed test here does, and takes a scope of its own. Verified: with a foreign marker in the environment the test fails with that refusal before this change; after it, the refusal is gone in both the marker and no-marker runs. Both runs then stop at Buf's BSR rate limit ("resource_exhausted: too many requests", no BSR login on this machine), and the unchanged test fails the same way with no marker, so that stop is environmental and not this change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TestConnectOnlyServiceSyncs(added in #113, 4c35bc0) generates bindings with Buf in a companion container, but it never takes a container recovery scope of its own.codefly publishruns the source tests below the agent process, so the test binary inherits the agent'sCODEFLY_CONTAINER_RECOVERY_SCOPE, and core refuses to create the container:That aborted the release-grade agent CI of the next python-fastapi release. GitHub CI sets no marker, so main is green.
The test now calls
ownTestContainers(t), asmain_test.goandlifecycle_matrix_test.goalready do ("Source tests run below the agent process, so its recovery marker is not ours").Classification
Fix, at the place that owns the behaviour: the new test skipped the repo's own helper. The ownership check is not touched.
Reused / not done
Reuses
ownTestContainers. No new mechanism.Verified
CODEFLY_CONTAINER_RECOVERY_SCOPE=99999:v2:<digest>:), the test fails with the refusal above before the change. After it, the refusal is gone, both with and without the marker.resource_exhausted: too many requests; this machine has no BSR login). The unchanged test fails identically with no marker set, so that stop is environmental.🤖 Generated with Claude Code