Repository navigation
build(deps): pin core at the v0.19.8 release, not a pre-squash commit of its branch - #201
Closed
antoinetoussaint-byte wants to merge 1 commit into
Closed
antoinetoussaint-byte wants to merge 1 commit into
antoinetoussaint-byte wants to merge 1 commit into
Conversation
… of its branch #199 landed pinning core v0.19.8-0.20261027211051-bc4e15cab5b0. That commit sits on core's codex/agent-download-auth-hint branch and is not reachable from core main: #819 was squash-merged, so the commit the pseudo-version names is orphaned, and the release that carries it is the v0.19.8 tag (a06da5fc). An agent release must pin a release, so this moves the pin to the tag. No source changes; go build and go vet pass. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
go.mod/go.sumonly: corev0.19.8-0.20261027211051-bc4e15cab5b0→v0.19.8(taga06da5fc). No source change.Why
#199 landed pinning a pseudo-version of
bc4e15ca, a commit on core'scodex/agent-download-auth-hintbranch. core#819 was squash-merged, so that commit is not reachable from coremain— it is an orphaned branch SHA, and the release that carries its content is thev0.19.8tag. v0.0.147 must ship on a release, not a commit the proxy happens to have cached.0f9b2001(thekern.bootsessionuuidBootID fix, core#802) is an ancestor ofa06da5fc: confirmed withgit merge-base --is-ancestor. v0.19.7 (557f6a3e) also carries it but lacksrunners.SignalProcess, whichnixpg.go:963now uses, so v0.19.8 is the lowest release this repo builds on.core#819's runtime-ownership change against this agent
dockerrun.WithServiceIdentity/ thecodefly.servicelabel exist only onDockerEnvironment(container path). The native path (nixpg.go, the run's shared server) never constructs one, so the label is never read or written there. This repo does not callWithServiceIdentity; on the container path an unlabelled config meetsvalidateContainerServiceReuse(labels, ""), which accepts a legacy (unlabelled) container and refuses only a container another agent has labelled with a different parent — a correct refusal, not a regression.runners/baseownership.go/pgid.go/process_identity_darwin.gochanges (signal re-verifies the birth after reading the audit-token version): the APIs this repo uses (runners.SignalProcess, process identity records) compile unchanged against the tag, and fix(runtime): preserve database claims and signal the recorded process birth #199's last commit was written against #819's branch.Gates
go mod tidyclean,go.sumcarries no credential.go build ./...,go vet ./...ok.go test ./...with CI's skip list: ok 614 s on this pin.Release
Once merged,
codefly publish patchfrom freshmaincuts v0.0.147 (0.0.146 → 0.0.147), the first release with #196 (one shared native server per run) and the clock-step-proof BootID.🤖 Generated with Claude Code