Repository navigation
fix: declare the migration choice for headless creation - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix at the owning agent: Options now declares gomigrate as its protocol default, matching the existing NewService/Create default. Headless generated-service conformance previously failed before Create because the migration-format choice had no declared default. The CLI remains fail-closed and does not guess an agent choice. Regression resolves every real creation question through communicate.AnswerDefault and checks the migration value. Full Go suite passed (43.327s plus migrations), go build and go vet passed. Release-grade conformance will rerun after this merges. Part of codefly-dev/core#622.