Repository navigation
Conversation
Independent platform review — ACCEPTED (design) / NOT QUALIFIED at this headFresh-context review under the The allocation across the two PRs is right — neither does the other's job, and the split follows G-B1 — blocker, reproduced: this PR's own new test is red at its committed Core pinAt Every other package passes. With This is the correct signal, not a mistake, and Worth correcting in the PR text: "the current released pin, Core v0.19.10" implies a boundary that does not exist. G-1 — medium, mutation-verified: the cross-target half has zero non-gated coverageReplacing Consequence: a future simplification ships a cross binary built from the pinned graph with an inventory describing a developer workspace, and CI notices nothing. Remedy: a table-driven unit test over The stack — the hazard here is a CI blackout, and it is unguarded
For contrast, The stranding hazard is latent rather than active: neither PR pins a same-repository SHA, and this PR's manifests carry only released tags. The split is defensible on its merits — the fixture depends on Advisory
Credit
The What was run
Not exercised: Nix integration (needs a sibling core checkout), the Linux runtime and Unsettled: whether |
A prepared Go workspace can link sibling modules that differ from the pinned graph. Package previously selected one inventory independently of each executable's build. This selects inventory per target: native builds use the prepared workspace; cross builds use the pinned graph available inside the companion.
Classification: fix at the package owner. It reuses Core's inventory and digest-bound artifact attachment, adds a public Package regression, and follows #159 . No second scanner or PDF/image capability is introduced.
Draft / blocked: the committed Core 0.19.10 dependency still produces invalid multi-main workspace evidence. Independent review reproduced the public Package test failure at
60d721eddbc62de4a069b740fc83612b5c0ed068with an unknown graph source; the pinned case passed. The owner fix is codefly-dev/core#878 and remains open. Adopting the inspected latest Core 0.19.18 alone does not fix this defect.Previously reported native/cross tests with a local Core override are exploratory evidence, not qualification of the committed pin. After an accepted Core release and supported adoption, rerun clean public Package, normal CLI bootstrap and generated-service delivery checks. Linux process execution/recovery and released artifacts remain separate obligations. This is not demonstrated as necessary for the already-running NYL PDF/image flow.