Repository navigation
chore: move to core v0.19.4 - #76
Merged
antoinetoussaint-byte merged 1 commit intoOct 13, 2026
Merged
Conversation
Bumps github.com/codefly-dev/core v0.5.1 -> v0.19.4 (released tag). MVS drags google.golang.org/grpc v1.83.2 -> v1.84.0 and refreshes indirect modules; go mod tidy keeps the go directive at 1.27.0 because core v0.19.4 declares 1.27.0. No call site needed adapting: the Agent, Runtime, Code and Tooling gRPC service interfaces are method-for-method identical between the two pins, and every core helper this agent calls kept its signature. kustomize stays on v0.21.1 and kube-openapi on d427ff9ee9ad, so the graph carries no structured-merge-diff/v7. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75.
Moves the generic agent from core v0.5.1 to core v0.19.4. The change is
go.modandgo.sumonly. No source file, workflow, image pin or doc changes, and the agent's responses are byte-identical to main's.Changes
github.com/codefly-dev/corev0.5.1 → v0.19.4google.golang.org/grpcv1.83.2 → v1.84.0 (direct)go.modandgo.sum(otel 1.47, x/net, x/sys, genproto, go-git, go-openapi/swag …)go mod tidyagainst the new core. Nothing was chosen by hand.There are no hacks: no
replace, no pseudo-version for any codefly module, no//nolint, no shim.Why no call site needed adapting
The gap from v0.5.1 to v0.19.4 is large, but this agent's surface didn't move:
*_grpc.pb.gomethod sets.services.NewServiceBase,services.Advertisement,services.RuntimeLoad,corecode.NewDefaultCodeServer,WithCachedFS,WithSemanticAnalyzer,NewSourceTooling,lang.NewEditToolboxFromTooling,agents.PluginRegistration,agents.Serve,resources.LoadServiceFromDir,failures.Ensureandfailures.Clone.Pins the go directive drags
None move. Core v0.19.4 declares
go 1.27.0, and aftergo mod tidythis repo's directive is stillgo 1.27.0. So:go-version-file: go.mod.ghcr.io/goreleaser/goreleaser-cross:v1.27.1-1already satisfies 1.27.0.No doc in the repo states the old core pin, so no doc changes. Open #57's AGENTS.md states
go.mod (1.27.0), which is still true.structured-merge-diff/v7
go mod graph | grep structured-merge-diff/v7prints nothing.go.modkeeps kustomize api/kyaml at v0.21.1 and kube-openapi atd427ff9ee9ad, so the issue's explicit downgrade wasn't needed.Legacy
Nothing in this repo is labelled legacy. One item is labelled legacy in core:
runtime.v0.TestResponse.status([deprecated = true], under core's "Legacy flat fields" heading).runtime.gopopulates it next to the typedresult. I left that alone on purpose:agents/services/base_runtime.goTestResponse*/typedTestErrorResponse,runners/golang/formula.go).Proof that behaviour is unchanged
I ran a throwaway in-package probe test (not committed) on main (306c623) and on this branch against the same local Maven/Java fixture. It dumped to normalized JSON:
GetAgentInformation(capabilities and README)GetSemanticIndex(the tree-sitter analyzer)The two dumps are byte-identical (11,387 bytes each).
What I reused
TestResponse.Status. This repo's agent is a producer of that field, so the same move doesn't apply here (see Legacy).Gates run locally
ci.ymlboundary job, aftergo clean -testcache:go build ./...,go vet ./...andgo test -count=1 -v ./.... 16 tests pass and 1 skips:TestAnyRegisteredBuilderServesConformantImageEvidence, which skips by design because no Builder is registered (same on main).releaser.ymltest job (go test -v ./...) is covered by the run above.releaser.ymlrelease job's build:goreleaser-cross:v1.27.1-1 build --snapshot --cleanbuilt all four CGO targets (darwin amd64/arm64, linux amd64/arm64).go mod tidy -diffis clean,go mod verifyreports all modules verified, and there are noreplacedirectives and no codefly pseudo-versions.What I did not verify
The real
release --cleanpublish path: the Syft-generated archive SBOMs and the GitHub release upload. I ranbuild --snapshotonly, because publishing is the coordinator's step.The release version bump.
agent.codefly.yamlstays at 0.0.39. This repo bumps it in a separaterelease: vXcommit when releasing (as with chore: pin core to v0.5.1 #69 → 306c623), so v0.0.40 is the coordinator's step.Lint. This repo has no lint gate in CI and no golangci config. A default
golangci-lintv2.14.0 run reports 4 issues, and the same 4 are on main:TestResponse.Status: one inruntime.go, two inagent_contract_test.go.service.go:71.I didn't touch them, to keep this PR to what the core move forces.
The real codefly CLI. I didn't load the built binary into it or run it end to end against a live workspace.
Overlap
Dependabot #73 bumps core to v0.7.0. This PR supersedes it, and #73 can be closed once this merges.
What I would file (not filed)
golangci-lintfindings. That means fixing the dead store atservice.go:71, then deciding whether the generic agent stops writing the deprecatedTestResponse.statusonce the consumers in the CLI and Mind read onlyresult.🤖 Generated with Claude Code