Repository navigation
fix: stage recipe inputs relative to the service build context - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix at the owning agent: DockerBuildRecipe.context is service-relative, while dockerfile is output_directory-relative. The agent emitted builder/envoy.yaml only beneath output_directory, but the real CLI supplies service/builder and invokes Docker from the service. This produced builder/builder/envoy.yaml, while COPY required builder/envoy.yaml. Stage the bootstrap in the service context and emit the Dockerfile directly into the requested recipe directory. Regression now checks COPY sources against the service root, and Docker buildx --check uses the protocol-defined context. Full suite passed (47.162s), build/vet passed. Actual release-grade conformance will rerun after merging. Part of codefly-dev/core#622.