Repository navigation
docs: adopt the fleet agent-context standard (#13) - #15
Merged
antoinetoussaint-byte merged 1 commit intoSep 28, 2026
Merged
antoinetoussaint-byte merged 1 commit into
antoinetoussaint-byte merged 1 commit into
Conversation
Adds a root AGENTS.md carrying what this repo owns and does not own, the build and test commands transcribed from .github/workflows/ci.yml, the cross-repo parity invariant with saas-sdk-go, and the behavioural rules from obin-ai/handbook#68. Procedural knowledge goes to .claude/skills/ rather than into the root file: regenerating the protobuf bindings, and changing anything covered by a fixture shared byte-for-byte with the Go SDK. CLAUDE.md is the one-line @AGENTS.md pointer the standard asks for, and tests/test_agent_context.py holds the whole arrangement in place — length budget, pointer, and a skill list that cannot drift from the directories. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13.
Summary
AGENTS.md(127 lines) now carries that: the ownership boundary (the protos belong tomodule-saas-starter, the transport to the solution runtime, the signer tosdk-go, and_gen/is never hand-edited), the commands transcribed from.github/workflows/ci.yml, the two version floors that only move together, and the behavioural rules from obin-ai/handbook#68 — anchored to things in this repo rather than stated in the abstract.saas-sdk-go, so editing one to go green locally removes the only signal that the two implementations disagree. That is the kind of change the standard means by hack, and the file says so..claude/skills/rather than into the root file —regenerate-bindings(the option-stripping step exists so this SDK never registers shared descriptors into the global pool) andwire-format-parity(the payload is closed by_reject_unknown, so a field added on the Go side and not here is a hard verification failure, not an ignored key). Both are read only when the task needs them.CLAUDE.mdis the one-line@AGENTS.mdpointer, so there is one canonical source. The issue framed this as "if aCLAUDE.mdis added later"; adding it now is what makes that true rather than aspirational.Classification: fix. No behaviour of the SDK changes; this adds the repo's missing agent context plus a test that keeps it honest.
Beyond the literal ask
tests/test_agent_context.py(5 tests) is not in the issue text. It enforces the standard's own conditions — root file ≤200 lines,CLAUDE.mdexactly@AGENTS.md, and per skill a validnamematching its directory, a non-emptydescription≤1024 chars, a body ≤500 lines — and asserts the skill list inAGENTS.mdis exactly the set of skill directories, so a renamed or deleted skill cannot leave a pointer aimed at nothing. handbook#68 asks that these files be treated as code;python -m pytest -qalready runs in CI, so this needs no workflow change. Two sibling adoptions (codefly-dev/core#536, obin-ai/module-record-store#41) added an equivalent guard. Say so if you would rather not carry it.Test plan
pip install -e ".[test,revision-connect,revision-grpc]"thenpython -m pytest -q— 143 passed (138 pre-existing + 5 new), run on both matrix interpreters: Python 3.10.21 and 3.12.14. Also passes on 3.14.7.AGENTS.mdwere run, not remembered — handbook#68 names unverified commands as an anti-pattern.CLAUDE.mdsomething other than the pointer, and paddingAGENTS.mdpast 200 lines each fail the specific test, and the tree was restored after each.key_idraisesunknown key id ...by name. The bullet now says the verifiable thing instead.Not verified: the
regenerate-bindingswalk was not executed — it needsbufand amodule-saas-startercheckout, and running it would rewrite_gen/, which does not belong in this pull request. It is transcribed fromscripts/generate.sh,buf.gen.yamlandSOURCE.txtas they stand. Likewise, no cross-repo change tosaas-sdk-gowas made or needed here.🤖 Generated with Claude Code