Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #32 for the new hand-written gateway/declaration changes. #28 retains the separate generated-contract prerequisite. This branch preserves the already-published development commit used by the demo; it is not the merge candidate.
Summary
Expose gateway-mediated module operation authority and audit event declaration through the public module-authority facade. Callers can use the existing host gateway rather than retaining a direct authority endpoint; declaration remains an Accounts-owned RPC.
Changes
Classification: fix at the SDK owner. No hand edits to generated bindings in the delta after #28.
Dependencies and review scope
This branch includes the prerequisite generated-contract and audit facade commits from #28 (through 903f025). Review that prerequisite once; the additional implementation is 903f025..278a7a6. Both currently target main because the prerequisite branch is on the contributor fork. Retarget/rebase after #28 merges. Uses the compatible host contract recorded in SOURCE.txt; it is not a migration to the newest host lifecycle.
Consumers: obin-ai/module-record-store#114 and obin-ai/core-solutions#386. The development fork pin is temporary until the reviewed upstream release is available.
Testing
GOWORK=off go build ./..., go vet ./..., and go test -race ./... pass, including the public API and agent-context gates. Gateway declaration and generic audit emission were also exercised by the local composed demo. Hosted CI and generated-binding reproduction remain subject to the upstream workflow; no production or hosted deployment qualification is claimed.