Repository navigation
chore: move to core v0.19.4 - #22
Merged
antoinetoussaint-byte merged 1 commit intoOct 13, 2026
Merged
Conversation
Pin github.com/codefly-dev/core to the released v0.19.4 tag in place of the v0.5.11-0.20260928114826-ae201a2288f1 pseudo-version, and raise the go directive to 1.27.2, the stdlib release that fixes the HIGH vulnerabilities `codefly publish` refuses at govulncheck. No source change is forced: every core symbol this agent uses kept its signature and value, and the generated harness is byte-identical (goldens pass). The README's statement of the pinned core is updated to match. Closes #21. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21.
Moves
github.com/codefly-dev/corefrom the pseudo-versionv0.5.11-0.20260928114826-ae201a2288f1to the released tag v0.19.4 and raises thegodirective from1.27.0to1.27.2. No Go source changes: core v0.19.4 didn't force any.Changes, classified
go.mod:core v0.19.4(released tag, noreplace, no pseudo-version);go mod tidyrefreshed indirects (grpc 1.83.2 → 1.84.0, otel 1.46 → 1.47, kube-openapi →d427ff9ee9ad, …)go.mod:go 1.27.2, notoolchainlinecodefly publishruns govulncheck on the built agent and refuses the HIGH stdlib vulnerabilities fixed in 1.27.2. CI pins Go withgo-version-file: 'go.mod', so CI follows without a workflow edit.README.md: "builds againstcodefly-dev/core v0.3.31" →v0.19.4No hacks.
What was reused, and what core changed
ci.ymlunchanged. Itsgo-version-filealready derives Go fromgo.mod, and it calls no core reusable workflows, so no@main→@v0.19.4pin was needed. Its two actions are already pinned by SHA.runnableserved-call constants the harness compiles in,resources.Runnable/RunnableExecution,agents, and the generated agent/builder/runtime protos. Evidence:go buildandgo vetpass with no source edit.pkg/generatepass withoutUPDATE_GOLDEN, so the generated harness is byte-identical.runnablepackage gained submit completion with a callback address, tool exposure, required scope slots, and a refusal of unknown operation-policy fields.resources/runnable.gochanged onlyVersion: "0.0.1"→InitialVersion. Adopting any of these would be a behaviour change, which is out of scope here.sdk-go,sdk-go/workcontextandsaas-sdk-goare not required by this module, so the issue's lines about them don't apply.agent.codefly.yamlis not changed. Its version stays0.0.5. The release bumps it.Verification
All three CI gates, run locally with Go 1.27.2 on darwin/arm64:
The suite builds the agent binary and serves gRPC from it (
serve_test.go). It also compiles generated packages withGOPROXY=offand runs a built harness as a process (pkg/generate).Dependency hygiene:
go mod graph | grep structured-merge-diff/v7prints nothing. go.mod lists kustomizev0.21.1and kube-openapiv0.0.0-20260721132016-d427ff9ee9ad, so no explicit downgrade was needed.go mod verifyreports all modules verified.Agent contract against core v0.19.4.
agents/contract.Check, so I ran a throwaway test besideserve_test.go. It is not committed, because this move PR changes only what core forces.CODEFLY_AGENT_UDS_PATH=empty). It then rancontract.CheckonGetAgentInformation().Contract, first with no required capabilities and then with every capability incontract.Current().protocol_version:1 capabilities:"container-recovery-scope/v1" startup_protocol_version:2, which is identical to core v0.19.4'scontract.Current().Not verified
go 1.27.2directive is what clears the stdlib findings, butcodefly publishwill be the first govulncheck run on this tree.codefly publish's release CI was not run. That includes therunnable-createconformance declared inagent.codefly.yaml, the cross-platform loader builds, and asset upload. I only ran the darwin/arm64 build and tests. GitHub CI covers linux build/vet/test.How this repo is released
There is no release workflow in
.github/workflows. Releases are cut bycodefly publishin agent mode:agent.codefly.yamlhaskind: codefly:runnableandrelease.owner: cli. In the CLI,cmd/publish/agent_release.goroutescodefly:runnableto the loader-asset releaser, andworkflow_release.gomakesowner: climean the operator's machine publishes, not a workflow. Release preconditions require darwin/arm64.release: vX.Y.Zcommit bumpingagent.codefly.yaml, on arelease-X.Y.Zbranch. That is the PR landing incmd/publish/landing.go.v0.0.2,v0.0.4andv0.0.5are signed annotated tags with messageVersion X.Y.Z, the exact stringcmd/publish/release.gowrites.So after review and merge, the release is: on darwin/arm64, from a clean
main, an operator runscodefly publish(patch bump, 0.0.5 → 0.0.6). It runs release agent CI, writes the version, commitsrelease: v0.0.6, lands it through therelease-0.0.6PR, pushes the signedv0.0.6tag, and creates the GitHub release with the loader assets. Don't hand-tag.What I would file (not filed)
serve_test.goshould assertcontract.Check(GetAgentInformation().Contract), so the contract proof above is a permanent test rather than a probe re-run on every core move.git tag -lis empty",version: 0.0.1) predates thecodefly publishreleases above, and its question is answered: this repo is released as a published artifact bycodefly publishwithrelease.owner: cli. I would comment that and close it instead of opening anything new.release: v0.0.3(release: v0.0.3 #16) has no tag. The merged commitf54ecf7bumped the manifest, butgit ls-remote --tags originlists only v0.0.2, v0.0.4 and v0.0.5. It's harmless for the next release because publish bumps from max(manifest, latest tag). It is a hole in the release record that the coordinator may want to note.🤖 Generated with Claude Code