Repository navigation
chore: bump core to v0.3.41 (#11) - #13
Merged
antoinetoussaint-byte merged 1 commit intoSep 21, 2026
Merged
Conversation
Crossing v0.3.39 is what makes this bump load-bearing rather than routine: core's agents/contract package first shipped there, and the standard interceptor chain fills AgentInformation.Contract from contract.Current() when the handler leaves it nil. At v0.3.31 that package did not exist, so this agent advertised no wire contract. go.mod and go.sum only; no API move on this jump reaches this repo. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11.
Summary
v0.3.31tov0.3.41, the version every codefly service agent was re-released against under Roll out core v0.3.41 across CLI, agents, saas-starter, modules and lodestar — the un-pinning sequence after #589 core#598.go.modandgo.sumonly — no source change, and none of the API moves that hit the service agents on this jump reach this repo (noSBOMImagescall, noValidateCoverage, noExpectedFromBuildPlan, norecoveryscopemarker).agents/contractpackage first shipped. An agent does not write its own contract declaration: the standard interceptor chain fills it in, atagents/agents.go:446→agents/container_recovery.go:28, which setsadvertisement.Contract = contract.Current()when the handler leaves it nil.main.go:42callsagents.Serve, so this agent is on that chain. Verified both ends in the module cache:agents/contractexists at v0.3.41 and does not exist at v0.3.31, where there is also nocontract.Current()call anywhere underagents/. Before this bump this agent advertised no wire contract; after it, it declares one.go mod tidy: grpc 1.83.1→1.83.2, otelgrpc 0.70.0→0.71.0,golang.org/x/{net,term,text}andgenproto/googleapis/rpc. Nothing else was touched.The release-path question in #11 — tracked in #12, not answered here
#11 asks whether this repo has a release path at all. Confirmed in this worktree that it does not:
git tag -lis empty,.github/workflows/contains onlyci.yml, andagent.codefly.yamldeclaresversion: 0.0.1with nothing that publishes it.That half is deliberately not settled in this PR. It is now #12, a sub-issue of umbrella #1, whose last open non-delegated checklist line it is. Filed by the #1 session rather than by me so the two sessions did not file it twice; it re-verified the three facts independently before filing, including zero tags via
git ls-remote --tags originand not just locally. This PR stays the clean bump.Why it matters and should not be papered over by hand-tagging: because the contract declaration is compiled into the binary by the interceptor above, it reaches a consumer only through a published build. If this repo is ever resolved as a published artifact, merging this bump to
mainadvertises nothing — precisely the failure mode that got the 17 service artifacts rejected in the core#598 rollout. So the question #12 leads with is whether this repo is consumed from source or as a published artifact; a missingreleaser.ymlis only the answer to one branch of it. It also carries the unchecked0.0.1↔v0.0.1manifest/tag coupling (codefly-dev/cli#758), which areleaser.ymllanding here would otherwise inherit from day one.Test plan
Full CI triple, run locally with
GOWORK=off, all clean on this branch:go build ./...— cleango vet ./...— cleango test ./...— all three packages pass:runnable-go122.5s,pkg/agent1.3s,pkg/generate104.8spkg/generate's golden comparison passes withoutUPDATE_GOLDEN, so generated output is byte-identical across the bump.serve_test.gobuilds the agent binary and speaks gRPC to it,pkg/generate/compile_test.gocompiles generated packages with the real toolchain underGOPROXY=off, andpkg/generate/invocation_test.goruns a built harness as a process.Not verified: that a published build of this agent is accepted by a consumer — this repo publishes nothing today, which is exactly what #12 tracks. The contract wiring is verified by source inspection of the linked core and by the agent taking
agents.Serve, not by observing a live handshake.🤖 Generated with Claude Code