Skip to content

fix(lint): check the three return values errcheck found in accounts and store tests #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antoinetoussaint-byte merged 1 commit into from
Nov 4, 2026
Merged

fix(lint): check the three return values errcheck found in accounts and store tests #1301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion module/services/accounts/code/pkg/adapters/rpc_policy_denied_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func TestUnauthenticatedCentralRefusalIsCounted(t *testing.T) {
reader := deniedReader(t)
refusal := membershipLookupStatus("verify central org scope", auth.ErrVerifiedDatabaseIdentityRequired)
require.Equal(t, codes.Unauthenticated, status.Code(refusal))
recordPolicyDenial(context.Background(), deniedMethod, denialReasonCentral, refusal)
require.Equal(t, refusal, recordPolicyDenial(context.Background(), deniedMethod, denialReasonCentral, refusal))
require.Equal(t, int64(1), deniedPoints(t, reader)[deniedMethod+" "+denialReasonCentral])
}

Expand Down
4 changes: 2 additions & 2 deletions module/services/store/code/migration_65_scope_settings_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func TestMigration65RenamesEveryScopeSettingAndNothingElse(t *testing.T) {
if err != nil {
t.Fatal(err)
}
defer runner.Close()
defer func() { _, _ = runner.Close() }()
if err := runner.Steps(-1); err != nil {
t.Fatal(err)
}
Expand Down Expand Up @@ -161,7 +161,7 @@ SELECT line FROM (
if err != nil {
t.Fatal(err)
}
defer rows.Close()
defer func() { _ = rows.Close() }()
var out []string
for rows.Next() {
var line string
Expand Down
Loading