Repository navigation
chore(accounts): mark the five adapter files as hand-maintained until service-go-grpc#223 - #1288
Merged
antoinetoussaint-byte merged 1 commit intoOct 31, 2026
Conversation
… service-go-grpc#223
accounts' pkg/adapters/{connect,cors,grpc,rest,server}_gen.go said "This
code is generated by the agent. Do not edit this file!", but the go-grpc
agent never writes them for accounts. In 0.1.72, generatedScaffoldTargets
renders the adapters only when the proto declares a single AccountsService.
Accounts serves many proto services and declares no AccountsService, so the
agent's Sync leaves the adapters alone. Moving the agent to 0.1.72 (#1287)
therefore did not regenerate them, and connect_gen.go has none of the
0.1.63-0.1.67 Connect-face bounds.
Each file now carries the STOPGAP (codefly-dev/service-go-grpc#223) header
that main.go and plugins/registry.go already carry. connect_gen.go also
states that it lacks those bounds. The comments in rest_extras.go and three
adapter tests that called these files "regenerated" now say they will be
adopted from the agent once #223 lands. Code is unchanged.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The three-pass review of platform-core#121 found that accounts'
pkg/adapters/connect_gen.gosays it is agent-generated, but #1287 did not regenerate it when accounts moved to go-grpc 0.1.72. It still serves Connect on a plainhttp.Server, so it has none of the 0.1.63-0.1.67 Connect-face bounds (message bound, body-read bound,ReadHeaderTimeout).What I decided, from source
I could not regenerate it, so this PR does not pretend to. In go-grpc v0.1.72 (
builder.go,generatedScaffoldTargets), the agent's Sync writes the five adapters (connect_gen.go,cors_gen.go,grpc_gen.go,rest_gen.go,server_gen.go) only when one proto file declares a single<Name>Service, hereAccountsService. No file underaccounts/protodeclaresAccountsService. Accounts serves many services through its own registration catalogs, so Sync never writes these files whatever version is pinned. That is the shape service-go-grpc#223 asks the agent to support.What changed
⚠️ This code is generated by the agent. Do not edit this file!header is replaced by theSTOPGAP (codefly-dev/service-go-grpc#223)header thatmain.goandplugins/registry.goalready carry. The new header says the files are hand-maintained, why the agent does not render them, and that the CUSTOM lines must be kept when the generated files are adopted.connect_gen.goalso says it lacks the Connect-face bounds.rest_extras.goand three adapter tests) now say the files will be adopted from the agent once feat: enforce an OIDC audience binding (#207) #223 lands. The tests keep guarding the CUSTOM lines against that adoption.connect_registration_catalog_gen.go,grpc_registration_catalog_gen.goandrest_registration_catalog_gen.goheaders are true, because this repo's owncmd/generators write those files, so they are unchanged.Classification: a stopgap label, not a fix. The fix is service-go-grpc#223. Until then, accounts' Connect listener stays unbounded. I recorded this on #223.
The review's other stale reference, the "saas 0.0.114 serves" comment, is in platform-core's
workspace.codefly.yaml. It is not in this repo, and0.0.114appears nowhere here. I did not touchdeployments/modules/saas, which also belongs to platform-core.Tests
go build ./...,go vet ./pkg/adapters,go test ./...: pass (every package ok, no failures)scripts/check-boundaries.sh: clean.node module/tools/naming-gate.mjs check(tree) andmessage(title, body, commit): clean.Not run:
codefly sync service accounts. Its outcome comes from reading the v0.1.72 source, and #1287 already reported that Sync is clean for accounts.🤖 Generated with Claude Code