Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft: map installation setup through Accounts
This candidate maps exact setup declarations, persisted Authority state, offers and issuance through the existing shared Authority core and signed delivery. It is an owner fix candidate; Accounts retains host identity and persistence rather than creating a separate policy engine.
Blocked; do not merge. Depends on Core and Authority, whose draft commits are not released at their upstream module paths. Released pins fail compilation with missing setup fields. The cross-repository interface needs an accepted handbook proposal, explicit owner agreement and independent design and implementation review. Authority's trusted-host fixture delivery cannot reach its callback without authentic attempt-bound evidence. This patch does not establish a production Accounts dispatcher or an end-to-end installation.
Based on current main 2e62b54, including the merged install and roles work. The open module page roles work changes shared installation/offer consumers and requires combined review and retesting. The proto and generated output carried from the existing candidate must be regenerated through Codefly and checked against all published clients before merge. No Postgres upgrade, visible first-use review, deployed installation or complete CI has been qualified. With local Core and Authority overrides,
go test ./pkg/adapters ./pkg/business ./pkg/infradid not pass: the adapters gateTestWorkloadOperationTableNamesEveryMintAndOwnerKindinvokesgo listwithGOWORK=off, so it cannot compile against the unreleased dependency pins. The remaining packages were interrupted before results; this is not a passing suite.Latest independent review and verification
Independent architecture-bouncer review at e6afb04 is conditional on the proposed owner contracts and blocks implementation qualification: selected published Core/Authority revisions cannot compile this change with GOWORK=off. Focused conversion/projection tests pass only with local owner overrides. Actual durable host/destination issuance, restart/replay and exact released combination remain unqualified.