Repository navigation
fix(proto): remove Rust generation and companion build tooling - #869
Merged
Merged
Conversation
antoinetoussaint-byte
enabled auto-merge (squash)
October 28, 2026 19:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proto companion compiled and shipped Rust generators even though Codefly client generation supports Go, Python, and TypeScript. Every multi-platform publication paid for the Rust toolchain and prost/tonic compilation, including this image-remediation rollout.
Remove the Rust Docker builder stage, Nix packages, templates, client-generation path, and Rust-only output handling and tests. Unsupported client-language requests now fail before touching their destination. Codefly remains the entry point for proto and client generation. This is a fix in Core, which owns the companion and generation implementation. Real-image qualification also exposed that Go Swagger generation omitted the existing WithPause lifecycle call and tried to exec in an exited container. The same lifecycle call used by proto and TypeScript generation fixes it; the previously failing TestGenerateSwagger now passes against the built image.
Release Core 0.19.13 and proto companion 0.0.21. Other refreshed companion versions stay as selected in 0.19.12; publication will resume from the merged Core commit using the patched CLI.
Documentation: docs/runbooks/bump-protobuf-es.md keeps its checked source citation current; companions/proto/README.md describes supported languages, the Codefly entry points, and the release/publication procedure.
Validation: version-tag guard, CGO-free guard, and proto package vet passed. The affected companions and proto package tests pass. A real ARM64 companion build through codefly companion build passed; executing that image confirms rustc, cargo, protoc-gen-prost, and protoc-gen-tonic are absent, while buf1.73.0, protoc-gen-go1.36.11, and protoc-gen-es2.11.0 run. The final full Core suite passed with exit 0. The complete tagged proto_companion_required suite passed against the built image (exit0,280.107s), including real Go/Python/TypeScript and Swagger generation. All six hosted multi-platform image builds passed. Hosted race and coverage passed. No NYL deployment or scan clearance is claimed.