Repository navigation
fix(workcontext): r142 follow-ups: authority rows at d091cc7a, conditional across-owners advice, empty-owner vector - #848
Merged
Conversation
…ional across-owners advice, empty-owner vector - docs/work-context.md: the three authority readers (hop.go:183, work_context.py:113/:218, codefly_hop:232) are owner-aware since authority #18 (f688c549); the issuer row names the one service, local, and its ListResources (issuer.go:88-126) and state.go coverageOf (:1346/:1359), read from a fresh clone at d091cc7a; Issue and Delegate refuse owners. - InheritResourceOwner advises one invocation per owner only when the owners split the scope by resource; when they split its actions it says no child can hold the whole scope and the parent must hold it under one owner. - resource_owner_vectors.json accepts the empty owner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #847 (merged at b57347f) from review r142: minors 1, 2, 4 and 5.
What changed
f1: the authority rows describe authority main. Authority #18 merged at f688c549, so the three authority readers are now owner-aware:
hop.go:183skips owner-selected scopes.work_context.py:113and:218keep the owner and compare it.codefly_hop/__init__.py:232skips owner-selected scopes.The rows say this, and say that only consumers pinned before f688c549 are still owner-blind. Every "(open)" is gone.
f2: one service, one issuer.
modules/authority/services/local/.../issuer.go:88-126(ListResources, withwholeat:103-104).state.go:1346(coverageOf, whole kind at:1359).Issuer:Issue(:205) andDelegate(:662) refuse owners throughrefuseOwners(:750).ListResourcesstill reads scopes itself and must become owner-aware before the issuer mints an owner.f4: the across-owners advice is conditional.
f5:
resource_owner_vectors.jsonnow has an accepted"no owner"("") vector.f3 (the authority's wire copy of the owner rule) belongs to codefly-dev/authority and is not in this PR.
Classification
Fix: docs, core's refusal wording and the shared test vectors. No hack.
Evidence
make buf-lintis clean.make buf-breaking: no breaking change against origin/main.go vet ./workcontext/...ok.go test -race -count=1 ./workcontext/... ./runnable/...ok."no owner"included. As before, the probe is not in CI.🤖 Generated with Claude Code