Repository navigation
fix(add): the playground builds the page's remote before running - #1230
Merged
Merged
Conversation
The backend answered 404 for /assets/mf-manifest.json — the manifest it
advertises in its own /.well-known/solution.json — so a host could
federate nothing and the page had no bundle to load.
The cause was not the address. The solution runtime serves /assets/ from
ASSETS_DIR, which already defaults to ../fe-remote/dist relative to the
backend; there was simply never a build there. The fleet's playground
runs its build-frontend.sh FIRST for exactly this reason, and the
scaffolded Makefile did not build the remote at all.
It now builds it and asserts the manifest exists before the run, so the
failure is a build error at the top rather than a 404 an hour later. The
shell installs the remote as a copy, so it needs it built too.
Verified on a clean scaffold:
dist/mf-manifest.json 1.7 kB
backend /assets/mf-manifest.json 200
{"id":"notes","exposes":["Page"]}
edge / 200 (signed in as alex)
edge /v1/notes/overview 200
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last open defect from running a scaffolded solution end to end: the backend answered 404 for
/assets/mf-manifest.json— the manifest it advertises in its own/.well-known/solution.json— so a host could federate nothing and the page had no bundle to load.It was not the address
I expected this to be
ASSETS_DIRand it is not. The solution runtime already defaults it to../fe-remote/distrelative to the backend, which is correct. There was simply never a build there.The fleet's playground runs
scripts/build-frontend.shfirst, which does exactly that build and then asserts the manifest exists. The scaffolded Makefile did not build the remote at all — so every scaffolded solution served an empty assets directory.The
test -fis deliberate: a missing bundle is now a build error at the top of the run rather than a 404 discovered much later. The shell installs the remote as a copy, so it needs it built too.Verified on a clean scaffold
Scope
One target in the scaffolded Makefile, its test, and the docs. Nothing else changes;
ASSETS_DIRis untouched because it was never wrong.Docs updated:
docs/commands.md.🤖 Generated with Claude Code