Repository navigation
Revert "feat(list): runnables carry the tool they are offered as, and each one's grant (#1207)" - #1210
Merged
Conversation
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#1207 merged at
ad957aeewith no review. The independent review at that commit (/tmp/codex-cli1207-review.md) reproduced two material defects:codefly list runnables --module other --env stagingreports validDOCUMENTS__…runnable-scope selections asunanswered_keys, while the unfiltered run of the same environment reports none. A selection the environment answers correctly is called unanswered because the check was scoped to the filtered module.--toolsdrops a runnable whosePolicy.Toolis nil, although the selected core'sToolFromPreparedalready synthesises the default (ApplyText/EFFECT_MUTATION). Core's contract is that every runnable is a tool; the tests added in feat(list): runnables carry the tool they are offered as, and each one's grant #1207 encode the old absence instead.The fix shape is known — reuse
ToolFromPreparedand validate the full graph before filtering, not second defaults — but that is new code with its own review, and it is not on blue's path. v0.1.220 therefore ships without #1207; it re-lands fixed in v0.1.221 under its owner.What this is
A plain
git revert -m 1 ad957aeeof the merge commit:cmd/list/runnables.go,cmd/generate/runnable_bindings.go,pkg/runnables/{derived,grant,projection}.go, their tests anddocs/{cli-reference,commands}.mdreturn to their state before #1207. Nothing else moved. Not merged until the release coordinator says so.Evidence
go build ./...;go test ./cmd/list/ ./cmd/generate/ ./pkg/runnables/ ./cmd/green (the CLI reference gate included, sincedocs/cli-reference.mdis reverted with the help text);golangci-lint runclean on the reverted packages.🤖 Generated with Claude Code