Repository navigation
fix: qualify local readiness, publication integrity and scoped process cleanup - #1202
Closed
antoinetoussaint-byte wants to merge 9 commits into
Closed
antoinetoussaint-byte wants to merge 9 commits into
antoinetoussaint-byte wants to merge 9 commits into
Conversation
…eck can run on a fresh checkout `codefly generate runnable-bindings` walks every composed module for its derived operations, but loaded the workspace with the plain loader. On a composition of pinned modules with no codefly.local.yaml — a CI job, or any fresh checkout — it refused before reading anything: module <wiki> resolves to a pinned artifact (source "obin-ai/core-solutions", version "0a18964f…"); pinned modules are pulled by the CLI, not loadable as a local checkout so `--check`, the one drift check this generated group has, could not be run where drift is caught. The command now materializes pinned modules first, exactly as `codefly run`, `deploy gitops render` and `generate fixture-composition` do (common.LoadWorkspaceWithPinnedModules), and is free once the workspace is materialized. Verified on obin-ai/platform-obin main (694ac3f4), environment blue: before, the refusal above; after, the check reaches the regeneration and refuses with the composition's real contradiction — `--call-endpoint "saas/auth-gateway/hop": service saas/auth-gateway declares no endpoint hop (it declares [grpc rest workload])` — while the committed configurations/blue/runnable-bindings.env binds 17 operations to their owners' direct in-cluster addresses, two of them on module compute, which the composition does not compose. First slice of making render and deploy refuse committed generated output that no longer matches what the generator would produce; the generic check on the readiness gate follows (see the handoff). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…t/runnable-bindings-check-materializes
Contributor
Author
|
Closed by the cli owner, unmerged and unreviewed as a stack, on the coordinator's instruction. This branch holds the 6-line Where each part goes:
The branch is kept, not deleted. |
github-merge-queue
Bot
removed this pull request from the merge queue due to a manual request
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix local readiness, release verification and process cleanup needed for CLI 0.1.220. Generated runnable checks now materialize selected modules and compare effective binding values; doctor respects environment exclusions. Publication verifies downloaded archives against producer checksums and GitHub digests, checks installer credentials through Core, and stamps tracked generated clients through the existing release transaction. Python stamps the semantic TOML project.version while preserving unrelated fields.
Stop consumes Core's authenticated registry APIs and persisted launch workspace, so child processes remain attributable after their controller exits or environment changes. It preserves incompatible birth evidence, refuses marker-only signaling, and cannot bypass registry refusal through agent-name or orphan fallback kills. Bounded reconciliation handles mixed producer generations. Historical root line/JSON compatibility remains; supported namespaces are decoded and signaled only by Core.
Validation:
Classification: fixes at their owners. Reuses Core registry discovery/authentication/identity-bound effects and installer credential rules, generator-owned bindings and TOML parsing, and the existing release transaction. No new registry, local generation pipeline, hosted fixture grant, or cloud deployment.
Docs updated: docs/commands.md, docs/cli-reference.md (generated), docs/orchestration.md, docs/publish-client-versions.md, docs/publish-verification.md, docs/supported-matrix.md.
Selects published Core v0.19.8 (a06da5fc), whose complete Go module contents equal reviewed bc4e15ca. Combined head e9cf1cf is pushed for CI. Local combined processgroup suite observed a 10-second dev-server scan timeout; three unchanged isolated reproductions passed, but a subsequent full-package run hit a different native-scan timeout. Independent investigation measured complete scans over ~2,300 processes, found no reproducible source regression, and passed the exact unmodified full package at clean e9cf1cf in 12.722s with all original deadlines. Precise cause of the two earlier delays remains unproven. No timeout or gate was weakened. Final-head CI and actual CLI publication verification remain required. Corrected agent publication and composition qualification proceed separately at their owners; this CLI release does not certify an unchanged old agent. No CLI 0.1.220 archive or checksum is claimed yet. ps remains a documented signature-based diagnostic view, narrower than registered stop discovery.