Repository navigation
fix(release): drop the cask's url.verified, which GoReleaser 2.18 refuses as deprecated - #1191
Merged
Merged
Conversation
…uses as deprecated The release image moved to goreleaser-cross v1.27.3 in #1101, which ships GoReleaser v2.18.3. Since v2.18.1 homebrew_casks.url.verified is deprecated (Homebrew deprecated the stanza in Homebrew/brew#23280 and GoReleaser no longer writes it into the cask), and `goreleaser check` exits non-zero on a deprecated property. The release workflow's 'Qualify the clean tag' step runs that check first, so v0.1.216's tag was qualified red and nothing published. Homebrew's default URL verification covers the release-download URL the template already names, so dropping the key removes nothing the cask carries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Local qualification of head
Not verified locally: notarization, which is disabled outside a real release, and the signature against the real release certificate, which needs the secret. |
crisfiorini-oss
pushed a commit
to crisfiorini-oss/cli
that referenced
this pull request
Oct 27, 2026
… published release, not the last tag (codefly-dev#1193) tools/agentcontract took the previous release to be the newest stable tag merged into HEAD, then downloaded that tag's agent-requirements.json and failed closed when the release was missing. A tag whose release workflow failed is a state the runbook expects (published tags are never moved), so one such tag blocked every later release: v0.1.216's workflow failed at 'Qualify the clean tag' (fixed by codefly-dev#1191), and v0.1.217's then failed at 'Prepare agent compatibility record' with 'release not found' for v0.1.216. The previous release is now the newest stable tag merged into HEAD that has a published (non-draft) GitHub release. Release listing errors still fail closed, and stable tags with no published release among them are an error rather than a silent first release. The listing is skipped when there is no stable tag to compare against. Co-authored-by: Antoine Toussaint <312536060+antoinetoussaint-byte@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
v0.1.216was tagged bycodefly publish(release PR #1190), but the release workflow failed at Qualify the clean tag before building anything (run 40437865278):#1101 moved the release image from
goreleaser-cross:v1.26.4tov1.27.3, which bundles GoReleaser v2.18.3. Since v2.18.1,homebrew_casks.url.verifiedis deprecated: Homebrew deprecated the stanza (Homebrew/brew#23280), and GoReleaser no longer writes it into the cask.goreleaser checkexits non-zero on any deprecated property. No PR workflow runs GoReleaser, so the first run under the new image was the tag.The change
Drops the one deprecated key. Homebrew's default URL verification covers the release-download URL the template already names.
.github/scripts/verify-homebrew-cask.shandpkg/cliupdate/release_contract_test.godo not read it.Classification: fix, at the config that owns the behaviour. No gate is relaxed, and the workflow's
checkstays as it is.Verified
goreleaser checkwith GoReleaser v2.18.3 (the same binary the image bundles): fails onmain(d3af5843) with the error above, passes on this branch.goreleaser-cross:v1.27.3 release --snapshot --clean, the 4-archive, SBOM and signature assertions) has been run against this head. The result is in the comment below.After merge
v0.1.216is a tag with no release. Perdocs/runbooks/cut-a-release.md, a published tag is never moved, so the nextcodefly publishcutsv0.1.217from main with this fix.🤖 Generated with Claude Code