Repository navigation
fix(doctor): recognize generated hop-route configuration supply - #1182
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full-workspace
doctor workspacereportsconfiguration_missingforhop-routeseven when orchestration successfully derives it from the routed module's authored contract and published API catalog. The records-scoped check passes because the consumer isauthority/hop, outside that scope.This is a fix in the CLI diagnostic that owns the availability check. Source validation used Core's authored-file inventory, while endpoint-reference validation used the orchestration inventory containing generated groups. Load
orchestration.WorkspaceConfigurationsForCheckingonce and share its result between both checks. Keep authored-file provenance, duplicate detection, ordinary required-group checks, and secret-reference checks. Do not exempthop-routesby name: it must actually be supplied by the existing loader.Reuse:
WorkspaceConfigurationsForChecking,NewWorkspaceConfigurationReader, Core's configuration composition, and the existing endpoint-reference check. No new route derivation, client, generated-file edit, runtime fallback, or dependency change.Validation:
obin-ai/module-record-store#201head126258015acd6d7fde5768e58146569f793090c3, its playground, and cached Authority pin683f8ff71a40a869e9d7d9a31ba9cabd6eb135cf. Before: records scope ready; full workspace fails only on missinghop-routes. After: full workspace, records scope, andauthority/hopscope all ready.go test ./cmd -run TestDoctorWorkspace -count=1;go test ./cmd ./pkg/orchestration ./pkg/gitops -count=1;go test -race ./cmd -count=1;golangci-lint run ./...(0 issues);git diff --check.CI passed at
58f74f9b4ddced0e81d172058abf95809d19a08b: Go CLI workflow (bootstrap audit, control integration, coverage, race, lint, dashboard), deployment contract, base guard, and all native recovery checks. The conditional pins job is skipped.This qualification runs the read-only doctor; it does not repeat service startup or hosted deployment. No changes to records or Authority are part of this PR.