Repository navigation
fix(environment): a configuration-source profile may carry the module envelope - #1154
Merged
antoinetoussaint-byte merged 1 commit intoOct 25, 2026
Conversation
… envelope Since #1151 a cell's module envelope is resolved through its configuration profile's derivation, so a shared hosted profile states it once (configurations/hosted/module-envelope.json). Importing an environment onto that profile then refused: "configuration-source supports only flat .env inputs and profile derivation metadata: module-envelope.json" — every new hosted cell, and any re-import of an existing one. The source-layer check now accepts the module envelope by its exact name (fixture.EnvelopeFile, the name the reader resolves); anything else stays refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Since #1151, a cell's module envelope is resolved through its configuration profile's derivation, so a shared hosted profile states it once (
configurations/hosted/module-envelope.json). Importing an environment onto that profile then refused:configuration-source supports only flat .env inputs and profile derivation metadata: module-envelope.json.That refusal hits every new hosted cell, and every re-import of an existing one. Found importing obin-dev, development's new platform cell.
What
The source-layer check accepts the module envelope by its exact name,
fixture.EnvelopeFile(now exported), which is the name the envelope reader resolves. Anything else stays refused.Classification: fix. It follows up my own #1151, which moved the envelope into the profile without teaching import about it.
Docs:
docs/commands.md(environment import, configuration source).Tests
TestProfileImportAcceptsTheSourceProfilesModuleEnvelopechecks that the exact name is accepted and a near name is refused.go test ./cmd/environment ./pkg/run/fixturepasses.🤖 Generated with Claude Code