Repository navigation
Conversation
Contributor
|
Superseded: native workload audiences for module calls predate the authority hop's signed single-use admission (codefly-dev/authority#28/#32) and the hop routing in #1188/#1189. Closed in the 2026-10-27 clean-up on the owner's instruction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A native workload currently receives only its host-audience credential. A second verifier cannot authenticate that workload under its own audience, even though Core already supports issuing and attesting such credentials. This adds explicit native projection/verifier declarations to the existing environment and launcher.
Draft prerequisite, not a completed consumer rollout. The intended Accounts-to-policy-log consumer is not implemented or qualified by this PR. The new declaration/carrier needs owner contract review and independent first-use/integration evidence before readiness.
Change and ownership
native-identityselects composed workloads and audiences through the existing resolved inventory. Only declared verifier recipients receive the native run anchor; each workload receives only its audience-to-file mapping. The existing host carrier/path remains compatible.File removal prevents further refresh; copied tokens remain usable until their existing expiry. Native mode retains the existing same-user laptop trust boundary and does not claim hostile-process isolation.
Current owner work
Based on main
ba55a971, including per-key secret stores; those tests pass on the combined tree. Main subsequently advanced to8ba93fffsolely for v0.1.198 metadata inpkg/cli/info.yaml; it changes no reviewed behavior and does not supersede this fix. Work Context key-set serving supplies a different capability and remains unmerged: itsauthority.Closemust be preserved alongside credential cleanup when integrated, followed by combined lifecycle verification. Neither change replaces this projection gap.Verification
GOWORK=off go test -race ./pkg/run/identity ./pkg/environments ./cmd/run ./pkg/orchestration ./pkg/gitopspassed.GOWORK=off go vetfor the same five packages andgo build ./cmd/codeflypassed.7e139393c1ce26af5832f09d57187b83ef2cea60. The integrated Flow→Manager→Runner withdrawal regression fails against the previous implementation and passes here. Other focused regressions cover wrong audiences, refresh, recipient isolation, graceful shutdown, cleanup retry, stop/restart through a local gRPC peer and remote refusal.Classification: owner fix, extending the existing native projection and lifecycle machinery. This PR does not replace the host witness client, evidence store, signing custody or permission resolver.