Repository navigation
fix(conformance): an already-exposed UnexposedTeam fails as a fixture error - #9
Merged
antoinetoussaint-byte merged 1 commit intoOct 26, 2026
Conversation
… error Against a long-lived authority a second run finds the fixed UnexposedTeam already exposed by the first; the grant is an idempotent no-op, the revision does not move, and the probe blamed the authority for missing staleness. The probe now reads the installation's teams through the administrator's List first and fails "UnexposedTeam %q is already exposed to %s" as a fixture error. The README and the field say the team must be one the installation does not reach when the run starts. Review follow-up f1 on #8. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This is review follow-up f1 on #8. When the suite runs against a long-lived authority, the second run finds the fixed
UnexposedTeamalready exposed by the first run.GrantToTeamthen changes nothing, the revision does not move, and the probe failed with "a token sealed before the organisation's authority moved is stale…". That message blamed the authority for a fixture problem.Before granting, the probe now reads the installation's
team_idsthrough the administrator'sInstallationService.List. If the team is already there, it fails as a fixture error:required conformance fixture invalid: UnexposedTeam %q is already exposed to %sThe README and the field's doc comment now say the team must be one the installation does not reach when the run starts, replacing "created or found".
Classification
This is a fix in the suite, where the misattributed message came from. It reuses the
Listread the lifecycle case already uses and adds no new interface.Evidence
go vet ./... && go test -race ./...inlibraries/conformance/go: passes. The package has no test files, so this is a compile and vet check.go test -race ./plugins/registry_testinmodules/authority/services/local/code:ok gateway/plugins/registry_test 34.825s.UnexposedTeam: "finance", a team wiki already reaches, the suite now fails withconformance.go:415: required conformance fixture invalid: UnexposedTeam "finance" is already exposed to fc555ea7-…. Before this change the same setup failed with the "not stale" message.Not verified: I did not run this against Accounts. Its fixture still has to set
UnexposedTeam, as #8 noted. I did not reproduce a literal second run against a running authority. The negative check covers the same state, a team the installation already reaches.Overlap
#6 and #7 still touch
libraries/conformance/go/conformance.go. This change stays inside the staleness probe (around line 405) and theUnexposedTeamfield comment, so no hunk overlap is expected.🤖 Generated with Claude Code