Repository navigation
fix: r148 on the core: a module is withdrawn, never uninstalled; tombstones hold their principal - #21
Merged
Merged
Conversation
…stones hold their principal; only an administrator learns what is installed - M1: Uninstall refuses a module's installation by name (a module is installed by composition and withdrawn, never uninstalled), and a delivery reactivates revoked module installations only after a withdrawal (the tombstone path). An administrator's uninstall of a solution stays. - m1: tombstones are found by principal too: no other module may claim a withdrawn module's principal, and Install refuses one. A tombstone is never cleared; a module that must change principal takes a new name. - m2: Uninstall gives the foreign answer to anyone but a current administrator of the organization named, before any installation read; a caller the store no longer knows belongs to no organization in every role call. - m3: issuance reports a store failure under the fence as itself, not as a refusal. Each new test (r148_test.go) was run against main's core and failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d it stays retired Only a person is refused uninstalling a module's installation. The host's setup (no caller) retiring one at an organization is kept across routine deliveries, since only a withdrawal and a redelivery reactivate a module's installations; the test covers both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What we are trying to do
Close review r148 on #20 before the local authority wires
Uninstallinto a host. The wrapper PR, which comes next, is what exposes it.The change (
libraries/authority-core/go)Uninstallrefuses a module's installation by name, asInstallalready refuses a module.ApplyModulereactivates revoked module installations only on the tombstone path, that is, after aWithdrawModule.Storecontract gainsTombstoneByPrincipal.Installrefuses one.domain.Tombstoneand on theStorecontract.Uninstallgives the foreign answer to anyone who is not a current administrator of the named organization, before any installation is read.Size
52 hand-written non-test lines and 124 test lines.
Classification
This is a fix at the owner. It reuses
decide.ForeignInstallationand the existing tombstone record; nothing new is added beside them.Tests
r148_test.go:sources_test.go: a member who administers nothing now gets the foreign answer.go vetandgo test -race -count=1withGOWORK=offpass inauthority-core,hop,conformanceandlocal/code.🤖 Generated with Claude Code